Skip to content

move keyboard logic inside keyboard flavour#574

Open
rovertrack wants to merge 2 commits intoscribe-org:mainfrom
rovertrack:keyboard-logic
Open

move keyboard logic inside keyboard flavour#574
rovertrack wants to merge 2 commits intoscribe-org:mainfrom
rovertrack:keyboard-logic

Conversation

@rovertrack
Copy link

#546

Contributor checklist

Description

moved from main/ to keyboard/

helpers only required by keyboard
helpers/

  • AnnotationTextUtils.kt
  • AutocompletionHandler.kt
  • BackspaceHandler.kt
  • Constants.kt
  • EmojiUtils.kt
  • KeyHandler.kt 
  • -KeyboardBase.kt
  • SpaceKeyProcessor.kt
  • SuggestionHandler.kt

ui /

  • KeyboardUIManager.kt (only required by keyboard)

services only required by keyboard

services /

  • FrenchKeyboardIME.kt
  • GeneralKeyboardIME.kt
  • ItalianKeyboardIME.kt
  • PortugueseKeyboardIME.kt
  • RussianKeyboardIME.kt
  • SpanishKeyboardIME.kt
  • SwedishKeyboardIME.kt

views only required by keyboard
views/

  • KeyboardView.kt

further we can extract keyboard-specific preference keys and keep only theme preferences - PreferencesHelper.kt

@github-actions
Copy link

Thank you for the pull request! 💙

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First PR Commit Check

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
    - The contributor's name and icon in remote commits should be the same as what appears in the PR
    - If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo (can be set with git config --global user.email "GITHUB_EMAIL")

@angrezichatterbox angrezichatterbox self-requested a review March 20, 2026 14:45
@angrezichatterbox
Copy link
Member

@rovertrack
The app is not building right now. Could you check whether fix the build errors and update the PR.

@andrewtavis
Copy link
Member

Thanks so much for the PR, @rovertrack :) Would you be able to fix the merge conflicts? Would be really helpful and we could get to the review soon after!

@rovertrack
Copy link
Author

sure @andrewtavis )

@andrewtavis
Copy link
Member

note, @rovertrack: Wait a moment as we're about to merge in a few other PRs. Then you can do the rebase. We'll be done soon :)

@andrewtavis
Copy link
Member

Or I guess it's fine to rebase to the current version of main as that will help with the next one 😊

@andrewtavis
Copy link
Member

You should be good to start with a rebase at your convenience, @rovertrack! We're bringing in one more PR, and then this one will be the highest priority :)

@rovertrack
Copy link
Author

Ok thanks @andrewtavis
Have moved the files to keyboards folder which are only required by it
Main issue occurs when I switch build flavour to conjugate
Will update this after fixing them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants