adds missing entries in the garmin devices dict#13
adds missing entries in the garmin devices dict#13socertis wants to merge 9 commits intoscrapper:masterfrom
Conversation
adding and updating missing message items, from the lates FIT Sdk Specification.
first_lap_index and serial number
scrapper
left a comment
scrapper
left a comment
There was a problem hiding this comment.
Why do you remove the fr920xt* entries and the fr620_taiwan entry?
scrapper
left a comment
scrapper
left a comment
There was a problem hiding this comment.
These changes look fine. Thanks for contributing!
scrapper
left a comment
scrapper
left a comment
There was a problem hiding this comment.
There are trailing whitespaces on the field 88 line. But otherwise these changes look good. Thanks for contributing!
scrapper
left a comment
scrapper
left a comment
There was a problem hiding this comment.
Why do you want to remove this check? This should be mandatory for all FIT files. Removing this can break applications like postrunner. Please remove this from the pull request.
scrapper
left a comment
scrapper
left a comment
There was a problem hiding this comment.
Why should this not be mandatory? Please remove from this pull requests.
scrapper
left a comment
scrapper
left a comment
There was a problem hiding this comment.
This has nothing to do with the changes to the tables. Please put this into a separate pull request.
Why should this not be a fatal problem?
scrapper
left a comment
scrapper
left a comment
There was a problem hiding this comment.
Please remove this from this pull request. Why should this not be fatal?
2 participants
i have noticed that the garmin devices are not all listed as in the latest fit sdk, so i added them.