Skip to content

Comments

Support quota as bigint#462

Open
maeldonn wants to merge 2 commits intodevelopment/8.5from
improvement/VLTCLT-54/support-bigint
Open

Support quota as bigint#462
maeldonn wants to merge 2 commits intodevelopment/8.5from
improvement/VLTCLT-54/support-bigint

Conversation

@maeldonn
Copy link

Issue: VLTCLT-54

@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2026

Hello maeldonn,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2026

Incorrect fix version

The Fix Version/s in issue VLTCLT-54 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.5.4

Please check the Fix Version/s of VLTCLT-54, or the target
branch of this pull request.

@maeldonn maeldonn requested review from a team, SylvainSenechal and benzekrimaha February 10, 2026 17:37
lib/IAMClient.js Outdated
const isBigInt = typeof quota === 'bigint';
const isNumber = typeof quota === 'number';
assert((isBigInt || isNumber) && quota >= 0, 'Quota must be a non-negative number or bigint');
data.quotaMax = quota.toString();
Copy link
Contributor

@francoisferrand francoisferrand Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we already support a string values for quota in all versions of Vault?
is this an issue (e.g. do we have a case where VaultClient may be used in a package which is used against different vault versions?)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we do. It works thanks to a trick in the validator.

@maeldonn maeldonn force-pushed the improvement/VLTCLT-54/support-bigint branch from 4c4813f to d1b14ca Compare February 12, 2026 07:46
Copy link

@SylvainSenechal SylvainSenechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double check François's comment about this client behavior against different versions of Vault, but I think its ok

@bert-e
Copy link
Contributor

bert-e commented Feb 17, 2026

Incorrect fix version

The Fix Version/s in issue VLTCLT-54 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.5.5

Please check the Fix Version/s of VLTCLT-54, or the target
branch of this pull request.

@maeldonn maeldonn force-pushed the improvement/VLTCLT-54/support-bigint branch from d1b14ca to 93c7f70 Compare February 19, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants