Open
Conversation
Contributor
Hello maeldonn,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Contributor
lib/IAMClient.js
Outdated
| const isBigInt = typeof quota === 'bigint'; | ||
| const isNumber = typeof quota === 'number'; | ||
| assert((isBigInt || isNumber) && quota >= 0, 'Quota must be a non-negative number or bigint'); | ||
| data.quotaMax = quota.toString(); |
Contributor
There was a problem hiding this comment.
do we already support a string values for quota in all versions of Vault?
is this an issue (e.g. do we have a case where VaultClient may be used in a package which is used against different vault versions?)
Author
There was a problem hiding this comment.
Yes, we do. It works thanks to a trick in the validator.
francoisferrand
approved these changes
Feb 11, 2026
4c4813f to
d1b14ca
Compare
SylvainSenechal
approved these changes
Feb 17, 2026
SylvainSenechal
left a comment
There was a problem hiding this comment.
double check François's comment about this client behavior against different versions of Vault, but I think its ok
Contributor
d1b14ca to
93c7f70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: VLTCLT-54