S3UTILS-223: add Claude Code PR review skill and CI workflow#374
S3UTILS-223: add Claude Code PR review skill and CI workflow#374nicolas2bert wants to merge 4 commits intodevelopment/1.17from
Conversation
Hello nicolas2bert,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development/1.17 #374 +/- ##
=================================================
Coverage 43.62% 43.62%
=================================================
Files 84 84
Lines 5973 5973
Branches 1255 1255
=================================================
Hits 2606 2606
Misses 3321 3321
Partials 46 46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
<br> renders as literal text inside code blocks and suggestion blocks in GitHub comments. Switch to $'...' quoting with \n for line breaks to ensure proper rendering.
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
CLAUDE.md already provides this context automatically, keeping it in SKILL.md risks divergence.
c92b1ce to
ca8248d
Compare
There was a problem hiding this comment.
Is the SKILL.md file needed for the CI review workflow? Or are we adding it to use locally?
There was a problem hiding this comment.
it is needed for the CI review workflow and also made to be used locally.
The reusable workflow use the skill to review: https://github.com/scality/agent-hub/blob/main/.github/workflows/claude-code-review.yml#L39
There was a problem hiding this comment.
I thought there was duplication between the review-pr SKILL.md in this repo, and https://github.com/scality/agent-hub/blob/main/.claude/skills/review-pr/SKILL.md. But actually (if I understand correctly), /setup-review-pr creates a review-pr in each repo, and when Claude is started by the CI review workflow, it reads the review-pr SKILL.md in the repo.
Not sure if/how it would be possible, but a future improvement could be to have a global review-pr SKILL in the agent-hub repo + local instructions in each repo.
That way, we can make improvements to the global review-pr skill and then get them into every repo by bumping the version.
|
@bert-e approve |
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option The following options are set: approve |
Build failedThe build for commit did not succeed in branch improvement/S3UTILS-223/claude-review The following options are set: approve |
No description provided.