Skip to content

S3UTILS-223: add Claude Code PR review skill and CI workflow#374

Open
nicolas2bert wants to merge 4 commits intodevelopment/1.17from
improvement/S3UTILS-223/claude-review
Open

S3UTILS-223: add Claude Code PR review skill and CI workflow#374
nicolas2bert wants to merge 4 commits intodevelopment/1.17from
improvement/S3UTILS-223/claude-review

Conversation

@nicolas2bert
Copy link
Contributor

No description provided.

@bert-e
Copy link
Contributor

bert-e commented Feb 25, 2026

Hello nicolas2bert,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Feb 25, 2026

Incorrect fix version

The Fix Version/s in issue S3UTILS-223 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.18.0

Please check the Fix Version/s of S3UTILS-223, or the target
branch of this pull request.

@nicolas2bert nicolas2bert changed the base branch from development/1 to development/1.17 February 25, 2026 14:58
@bert-e
Copy link
Contributor

bert-e commented Feb 25, 2026

Incorrect fix version

The Fix Version/s in issue S3UTILS-223 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 1.17.5

  • 1.18.0

Please check the Fix Version/s of S3UTILS-223, or the target
branch of this pull request.

@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.62%. Comparing base (b576902) to head (4158e99).

Additional details and impacted files
@@                Coverage Diff                @@
##           development/1.17     #374   +/-   ##
=================================================
  Coverage             43.62%   43.62%           
=================================================
  Files                    84       84           
  Lines                  5973     5973           
  Branches               1255     1255           
=================================================
  Hits                   2606     2606           
  Misses                 3321     3321           
  Partials                 46       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

<br> renders as literal text inside code blocks and suggestion blocks
in GitHub comments. Switch to $'...' quoting with \n for line breaks
to ensure proper rendering.
@bert-e
Copy link
Contributor

bert-e commented Feb 25, 2026

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

CLAUDE.md already provides this context automatically, keeping it
in SKILL.md risks divergence.
@nicolas2bert nicolas2bert force-pushed the improvement/S3UTILS-223/claude-review branch from c92b1ce to ca8248d Compare February 26, 2026 10:11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the SKILL.md file needed for the CI review workflow? Or are we adding it to use locally?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is needed for the CI review workflow and also made to be used locally.
The reusable workflow use the skill to review: https://github.com/scality/agent-hub/blob/main/.github/workflows/claude-code-review.yml#L39

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought there was duplication between the review-pr SKILL.md in this repo, and https://github.com/scality/agent-hub/blob/main/.claude/skills/review-pr/SKILL.md. But actually (if I understand correctly), /setup-review-pr creates a review-pr in each repo, and when Claude is started by the CI review workflow, it reads the review-pr SKILL.md in the repo.

Not sure if/how it would be possible, but a future improvement could be to have a global review-pr SKILL in the agent-hub repo + local instructions in each repo.
That way, we can make improvements to the global review-pr skill and then get them into every repo by bumping the version.

@nicolas2bert
Copy link
Contributor Author

@bert-e approve

@bert-e
Copy link
Contributor

bert-e commented Feb 26, 2026

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.13
  • development/1.14
  • development/1.15
  • development/1.16
  • development/1.4
  • development/1.7

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Feb 26, 2026

Build failed

The build for commit did not succeed in branch improvement/S3UTILS-223/claude-review

The following options are set: approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants