Skip to content

Comments

Properly use sub clients of cloudserver client#372

Merged
bert-e merged 4 commits intodevelopment/1.17from
bugfix/S3UTILS-221
Feb 10, 2026
Merged

Properly use sub clients of cloudserver client#372
bert-e merged 4 commits intodevelopment/1.17from
bugfix/S3UTILS-221

Conversation

@SylvainSenechal
Copy link
Contributor

ISSUE: S3UTILS-221

@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2026

Hello sylvainsenechal,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.62%. Comparing base (74911f3) to head (b576902).
⚠️ Report is 4 commits behind head on development/1.17.

Files with missing lines Patch % Lines
Clients/CloudserverClient.js 0.00% 5 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           development/1.17     #372   +/-   ##
=================================================
  Coverage             43.62%   43.62%           
=================================================
  Files                    84       84           
  Lines                  5973     5973           
  Branches               1255     1255           
=================================================
  Hits                   2606     2606           
  Misses                 3321     3321           
  Partials                 46       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SylvainSenechal SylvainSenechal marked this pull request as ready for review February 10, 2026 10:43
@SylvainSenechal SylvainSenechal changed the base branch from development/1.7 to development/1.17 February 10, 2026 10:45
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should've seen it, not sure what happened but probably bumped Cloudserver client to latest version after doing the tests, needs to use sub clients like this (or could also directly import the sub client but this is fine)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, not affecting dev/1.16

@scality scality deleted a comment from bert-e Feb 10, 2026
@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2026

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@SylvainSenechal SylvainSenechal requested review from a team, benzekrimaha and maeldonn February 10, 2026 10:50
@SylvainSenechal
Copy link
Contributor Author

/create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2026

Integration data created

I have created the integration data for the additional destination branches.

  • this pull request will merge bugfix/S3UTILS-221 into
    development/1.17
  • w/1/bugfix/S3UTILS-221 will be merged into development/1

The following branches will NOT be impacted:

  • development/1.13
  • development/1.14
  • development/1.15
  • development/1.16
  • development/1.4
  • development/1.7

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

@SylvainSenechal
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Feb 10, 2026

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.17

  • ✔️ development/1

The following branches have NOT changed:

  • development/1.13
  • development/1.14
  • development/1.15
  • development/1.16
  • development/1.4
  • development/1.7

Please check the status of the associated issue S3UTILS-221.

Goodbye sylvainsenechal.

The following options are set: approve, create_integration_branches

@bert-e bert-e merged commit b576902 into development/1.17 Feb 10, 2026
11 of 12 checks passed
@bert-e bert-e deleted the bugfix/S3UTILS-221 branch February 10, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants