S3UTILS-217: improve listObjectsByReplicationStatus.js

[scality-gdoumergue]

• Show details of the errors when they happen
• Display the bucket's name
• Display the IsLatest field

This script has been tested in a lab:

• When the bucket doesn't exist: The script logs a 404 HTTP code error
• When the bucket is not versioned nor replicated: the script doesn't break
• When the ak/sk pair is wrong: The script logs a 403 HTTP code error
• When the IAM user doesn't have the right to list the bucket: The script logs a 403 HTTP code error
• When the IAM user doesn't have the right to HEAD objects: The script logs a 403 HTTP code error

[bert-e]

Hello scality-gdoumergue,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Incorrect fix version

The Fix Version/s in issue S3UTILS-217 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 1.18.0

Please check the Fix Version/s of S3UTILS-217, or the target
branch of this pull request.

[codecov]

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 43.78%. Comparing base (d938738) to head (5166ff8).
⚠️ Report is 7 commits behind head on development/1.

Files with missing lines	Patch %	Lines
listObjectsByReplicationStatus.js	80.00%	1 Missing ⚠️

Additional details and impacted files

@@                Coverage Diff                @@
##           development/1     #367      +/-   ##
=================================================
+ Coverage          43.76%   43.78%   +0.02%     
=================================================
  Files                 84       84              
  Lines               5962     5966       +4     
  Branches            1256     1256              
=================================================
+ Hits                2609     2612       +3     
- Misses              3307     3308       +1     
  Partials              46       46              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[tcarmet]

Code itself LGTM, nothing to say here.

But, recently I spent some time to make sure we can test this script in the CI, previously there was none. So if you have the time in hand, and can have a look at this file and if you are able to add some tests that would be great. If not, no worries, I'll take note and create a ticket on my end to do so.

Some notes:

Those tests do require a tool we created to simulate a small s3c env called workbench, to install it:

curl -L -o /tmp/workbench.tar.gz https://github.com/scality/workbench/releases/download/v0.8.0/workbench_Linux_x86_64.tar.gz
tar -xzf /tmp/workbench.tar.gz -C /tmp
sudo install /tmp/workbench /usr/local/bin/workbench

Run it inside s3utils repo, like so:

workbench up --env-dir ./workbench/env -d

You'll then be able to run those particular test like so:

yarn jest --verbose --logHeapUsage --projects jest.config.js  --coverage --testPathPattern='tests/functional/listObjectsByReplicationStatus.js'

Again, only if you have the time in hand, just let me know.

[scality-gdoumergue]

Thanks @tcarmet , I will use workbench to improve my knowledge!

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• 2 peers

[scality-gdoumergue]

/approve

[bert-e]

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

• ✔️ development/1

The following branches will NOT be impacted:

• development/1.13
• development/1.14
• development/1.15
• development/1.16
• development/1.17
• development/1.4
• development/1.7

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

• Any commit you add on the source branch will trigger a new cycle after the
  current queue is merged.
• Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

[bert-e]

I have successfully merged the changeset of this pull request
into targetted development branches:

• ✔️ development/1

The following branches have NOT changed:

• development/1.13
• development/1.14
• development/1.15
• development/1.16
• development/1.17
• development/1.4
• development/1.7

Please check the status of the associated issue S3UTILS-217.

Goodbye scality-gdoumergue.