Manage CRR endpoints without explicit port

[maeldonn]

Issue: ARTESCA-16783

[bert-e]

Hello maeldonn,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Incorrect Jira project

The Jira issue ARTESCA-16783 specified in the source
branch name, does not belong to project BB.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.71%. Comparing base (02be9e5) to head (6c8abd2).
⚠️ Report is 7 commits behind head on development/9.1.

Additional details and impacted files

Files with missing lines	Coverage Δ
...sions/replication/queueProcessor/QueueProcessor.js	73.60% <100.00%> (+0.66%)	⬆️

... and 3 files with indirect coverage changes

Components	Coverage Δ
Bucket Notification	80.37% <ø> (ø)
Core Library	80.67% <ø> (-0.60%)	⬇️
Ingestion	70.84% <ø> (ø)
Lifecycle	78.70% <ø> (ø)
Oplog Populator	85.06% <ø> (ø)
Replication	61.18% <100.00%> (+0.09%)	⬆️
Bucket Scanner	85.76% <ø> (ø)

@@                 Coverage Diff                 @@
##           development/9.1    #2718      +/-   ##
===================================================
- Coverage            74.94%   74.71%   -0.23%     
===================================================
  Files                  201      201              
  Lines                13517    13518       +1     
===================================================
- Hits                 10130    10100      -30     
- Misses                3377     3408      +31     
  Partials                10       10              

Flag	Coverage Δ
api:retry	9.25% <0.00%> (-0.01%)	⬇️
api:routes	9.06% <0.00%> (-0.01%)	⬇️
bucket-scanner	85.76% <ø> (ø)
ft_test:queuepopulator	9.08% <0.00%> (-1.29%)	⬇️
ingestion	12.62% <0.00%> (-0.01%)	⬇️
lib	7.80% <0.00%> (-0.01%)	⬇️
lifecycle	18.95% <0.00%> (-0.01%)	⬇️
notification	1.03% <0.00%> (-0.01%)	⬇️
replication	18.87% <100.00%> (+<0.01%)	⬆️
unit	50.92% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[SylvainSenechal]

why is getQueueProcessorConfig returning an array instead of an object 😆

[benzekrimaha]

lgtm

[francoisferrand]

Issue: ARTESCA-16783

Backbeat PR must reference a Backbeat ticket (BB-xxx), not an Artesca ticket, c.f. message from Bert-e:

The Jira issue ARTESCA-16783 specified in the source
branch name, does not belong to project BB.

so you will need to reopen this PR with a different branch name

[francoisferrand]

can't the transport be specified in each replication endpoint?

[maeldonn]

Transport IS already resolved per-site (config.getReplicationSiteDestConfig()). The varible destConfig is constructed per-site, so the transport is not a global value, but the current site transport.

[francoisferrand]

is this really the only place where the server port is added?

if in doubt, "validating" input (and handling default) may be done when loading the configuration, to ensure it is available later in every case

[maeldonn]

Moved to #2721