Skip to content

Run zenko tests in codespace + some cleanup of unused files#2324

Open
SylvainSenechal wants to merge 2 commits intodevelopment/2.14from
improvement/ZENKO-5181
Open

Run zenko tests in codespace + some cleanup of unused files#2324
SylvainSenechal wants to merge 2 commits intodevelopment/2.14from
improvement/ZENKO-5181

Conversation

@SylvainSenechal
Copy link
Contributor

Issue: ZENKO-5181

@SylvainSenechal SylvainSenechal requested review from a team, delthas and maeldonn February 16, 2026 17:48
@SylvainSenechal SylvainSenechal marked this pull request as draft February 16, 2026 17:49
"ghcr.io/devcontainers/features/docker-in-docker": {},
"ghcr.io/devcontainers/features/github-cli:1": {},
"ghcr.io/devcontainers/features/node:1": {},
"ghcr.io/devcontainers/features/python:1": {},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python is already available in the codespace, but some yarn install command because something "gyp" related to python failed to install. This should fix it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to running zenko tests in Codespace, but I did some decluttering in this pr and removed 4 unused files (removed docker entry point, and the associated files that werent used by anything else)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This structure and usage is very similar to what I did for the Cucumber tests.
Tbh, I was also able to run the test without a pod, but it required port forward, and using different values for some variables, which later will probably become annoying because we don't want to have to deal with 2 values for the same variables depending on whether the test is running in github ci or codespace.
So maybe later we'll come back to this if we decide to run all tests outside of cluster, but don't really wanna deal with it for now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in any case, we should not have separate scripts for local vs CI setups, as they will diverge over time and/or add duplicate work : so a good first step, but it will need to be reworked indeed

  • ideally, running "locally" (even in codespace) will be easier (frictionless), faster (no copy/reload), and allow debugging more easily
  • we may run in CI "locally" as well (which avoids a docker rebuild, and can leverage gha cache to speedup yarn install)
  • or at least somehow "merge" the scripts used in CI and locally

TEST_GREP="${1:-should list objects in V2 format}"
TEST_PATH="${2:-cloudserver}"

ZENKO_ACCESS_KEY=$(kubectl get secret end2end-management-account-creds.v1 -o jsonpath='{.data.accessKey}' | base64 -d)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These env variables will eventually be removed (calculated automatically from within the test)

@SylvainSenechal SylvainSenechal force-pushed the improvement/ZENKO-5180 branch 12 times, most recently from 59e3b03 to 90d69c5 Compare February 17, 2026 14:23
@SylvainSenechal SylvainSenechal marked this pull request as ready for review February 17, 2026 16:36
Comment on lines +23 to +24
TEST_GREP="${1:-should list objects in V2 format}"
TEST_PATH="${2:-cloudserver}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it not run "all" tests by default?

Base automatically changed from improvement/ZENKO-5180 to development/2.14 February 19, 2026 18:16
@bert-e
Copy link
Contributor

bert-e commented Feb 19, 2026

Hello sylvainsenechal,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Feb 19, 2026

Incorrect fix version

The Fix Version/s in issue ZENKO-5181 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 2.14.0

Please check the Fix Version/s of ZENKO-5181, or the target
branch of this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments