Run zenko tests in codespace + some cleanup of unused files#2324
Run zenko tests in codespace + some cleanup of unused files#2324SylvainSenechal wants to merge 2 commits intodevelopment/2.14from
Conversation
| "ghcr.io/devcontainers/features/docker-in-docker": {}, | ||
| "ghcr.io/devcontainers/features/github-cli:1": {}, | ||
| "ghcr.io/devcontainers/features/node:1": {}, | ||
| "ghcr.io/devcontainers/features/python:1": {}, |
There was a problem hiding this comment.
Python is already available in the codespace, but some yarn install command because something "gyp" related to python failed to install. This should fix it
There was a problem hiding this comment.
Unrelated to running zenko tests in Codespace, but I did some decluttering in this pr and removed 4 unused files (removed docker entry point, and the associated files that werent used by anything else)
There was a problem hiding this comment.
This structure and usage is very similar to what I did for the Cucumber tests.
Tbh, I was also able to run the test without a pod, but it required port forward, and using different values for some variables, which later will probably become annoying because we don't want to have to deal with 2 values for the same variables depending on whether the test is running in github ci or codespace.
So maybe later we'll come back to this if we decide to run all tests outside of cluster, but don't really wanna deal with it for now
There was a problem hiding this comment.
in any case, we should not have separate scripts for local vs CI setups, as they will diverge over time and/or add duplicate work : so a good first step, but it will need to be reworked indeed
- ideally, running "locally" (even in codespace) will be easier (frictionless), faster (no copy/reload), and allow debugging more easily
- we may run in CI "locally" as well (which avoids a docker rebuild, and can leverage gha cache to speedup yarn install)
- or at least somehow "merge" the scripts used in CI and locally
| TEST_GREP="${1:-should list objects in V2 format}" | ||
| TEST_PATH="${2:-cloudserver}" | ||
|
|
||
| ZENKO_ACCESS_KEY=$(kubectl get secret end2end-management-account-creds.v1 -o jsonpath='{.data.accessKey}' | base64 -d) |
There was a problem hiding this comment.
These env variables will eventually be removed (calculated automatically from within the test)
59e3b03 to
90d69c5
Compare
34dcaad to
d0158a6
Compare
d0158a6 to
1df64ba
Compare
1df64ba to
11d9d19
Compare
| TEST_GREP="${1:-should list objects in V2 format}" | ||
| TEST_PATH="${2:-cloudserver}" |
There was a problem hiding this comment.
should it not run "all" tests by default?
Hello sylvainsenechal,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
Issue: ZENKO-5181