Deploy a SASL_SCRAM Kafka listener & test notifications against it#2323
Deploy a SASL_SCRAM Kafka listener & test notifications against it#2323delthas wants to merge 3 commits intodevelopment/2.13from
Conversation
Hello delthas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
There was a problem hiding this comment.
Pull request overview
This pull request adds SCRAM-SHA-512 authentication support for Kafka notification destinations, complementing the existing SASL_PLAIN authentication mechanism. The changes enable testing bucket notifications against a SCRAM-authenticated Kafka listener, which is deployed alongside the existing PLAIN authentication listener on the same Kafka broker.
Changes:
- Added a new SCRAM-SHA-512 authenticated Kafka listener (port 9095) for testing notifications
- Created test scenarios for SCRAM authentication following the same pattern as PLAIN authentication tests
- Updated dependencies (backbeat 9.1.7, zenko-operator v1.8.3) to support the new authentication mechanism
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/ctst/world/Zenko.ts | Added SCRAM authentication parameters (destination name, topic, username, password, and hosts) to the test interface |
| tests/ctst/steps/notifications.ts | Implemented "one SCRAM authenticated notification destination" step using the existing setNotificationDestination helper |
| tests/ctst/features/bucket-notifications/notifications.feature | Added test scenario for SCRAM authentication with the same test cases as PLAIN authentication (3 versioning configurations) |
| solution/deps.yaml | Updated backbeat to 9.1.7 and zenko-operator to v1.8.3 |
| .github/workflows/end2end.yaml | Added environment variables for SCRAM destination configuration (name, topic, username, password) |
| .github/scripts/end2end/run-e2e-ctst.sh | Added KAFKA_SCRAM_HOST_PORT variable and passed SCRAM parameters to test configuration |
| .github/scripts/end2end/configure-e2e-ctst.sh | Configured Kafka broker with both PLAIN (port 9094) and SCRAM-SHA-512 (port 9095) listeners, created SCRAM topic |
| .github/scripts/end2end/configs/notification_destinations.yaml | Added ZenkoNotificationTarget resource for SCRAM authentication with SHA-512 mechanism |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e9417de to
3f52903
Compare
3f52903 to
6cfe5b5
Compare
|
/create_integration_branches |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_integration_branches |
|
/after_pull_request #2331 |
Waiting for other pull request(s)The current pull request is locked by the after_pull_request option. In order for me to merge this pull request, run the following actions first: ➡️ Merge the
Alternatively, delete all the after_pull_request comments from this pull request. The following options are set: after_pull_request, create_integration_branches |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following options are set: create_integration_branches |
Issue: ZENKO-5175
Relates to: #2300