Skip to content

Deploy a SASL_SCRAM Kafka listener & test notifications against it#2323

Open
delthas wants to merge 3 commits intodevelopment/2.13from
improvement/ZENKO-5175/kafka-sasl-scram
Open

Deploy a SASL_SCRAM Kafka listener & test notifications against it#2323
delthas wants to merge 3 commits intodevelopment/2.13from
improvement/ZENKO-5175/kafka-sasl-scram

Conversation

@delthas
Copy link
Contributor

@delthas delthas commented Feb 16, 2026

Issue: ZENKO-5175

Relates to: #2300

@bert-e
Copy link
Contributor

bert-e commented Feb 16, 2026

Hello delthas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@delthas delthas requested a review from Copilot February 16, 2026 15:51
@scality scality deleted a comment from bert-e Feb 16, 2026
@bert-e
Copy link
Contributor

bert-e commented Feb 16, 2026

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds SCRAM-SHA-512 authentication support for Kafka notification destinations, complementing the existing SASL_PLAIN authentication mechanism. The changes enable testing bucket notifications against a SCRAM-authenticated Kafka listener, which is deployed alongside the existing PLAIN authentication listener on the same Kafka broker.

Changes:

  • Added a new SCRAM-SHA-512 authenticated Kafka listener (port 9095) for testing notifications
  • Created test scenarios for SCRAM authentication following the same pattern as PLAIN authentication tests
  • Updated dependencies (backbeat 9.1.7, zenko-operator v1.8.3) to support the new authentication mechanism

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/ctst/world/Zenko.ts Added SCRAM authentication parameters (destination name, topic, username, password, and hosts) to the test interface
tests/ctst/steps/notifications.ts Implemented "one SCRAM authenticated notification destination" step using the existing setNotificationDestination helper
tests/ctst/features/bucket-notifications/notifications.feature Added test scenario for SCRAM authentication with the same test cases as PLAIN authentication (3 versioning configurations)
solution/deps.yaml Updated backbeat to 9.1.7 and zenko-operator to v1.8.3
.github/workflows/end2end.yaml Added environment variables for SCRAM destination configuration (name, topic, username, password)
.github/scripts/end2end/run-e2e-ctst.sh Added KAFKA_SCRAM_HOST_PORT variable and passed SCRAM parameters to test configuration
.github/scripts/end2end/configure-e2e-ctst.sh Configured Kafka broker with both PLAIN (port 9094) and SCRAM-SHA-512 (port 9095) listeners, created SCRAM topic
.github/scripts/end2end/configs/notification_destinations.yaml Added ZenkoNotificationTarget resource for SCRAM authentication with SHA-512 mechanism

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@delthas delthas force-pushed the improvement/ZENKO-5175/kafka-sasl-scram branch 5 times, most recently from e9417de to 3f52903 Compare February 17, 2026 13:43
@delthas delthas marked this pull request as ready for review February 18, 2026 08:26
@delthas delthas requested review from a team, DarkIsDude and SylvainSenechal February 18, 2026 08:26
@delthas delthas changed the title Deploy a SASL_PLAIN Kafka listener & test notifications against it Deploy a SASL_SCRAM Kafka listener & test notifications against it Feb 18, 2026
@delthas delthas force-pushed the improvement/ZENKO-5175/kafka-sasl-scram branch from 3f52903 to 6cfe5b5 Compare February 18, 2026 20:59
@delthas
Copy link
Contributor Author

delthas commented Feb 18, 2026

/create_integration_branches

@scality scality deleted a comment from bert-e Feb 19, 2026
@bert-e
Copy link
Contributor

bert-e commented Feb 19, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

@francoisferrand
Copy link
Contributor

francoisferrand commented Feb 19, 2026

/after_pull_request #2331

@bert-e
Copy link
Contributor

bert-e commented Feb 19, 2026

Waiting for other pull request(s)

The current pull request is locked by the after_pull_request option.

In order for me to merge this pull request, run the following actions first:

➡️ Merge the OPEN pull request:

Alternatively, delete all the after_pull_request comments from this pull request.

The following options are set: after_pull_request, create_integration_branches

@bert-e
Copy link
Contributor

bert-e commented Feb 19, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following options are set: create_integration_branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments