ft: ARSN-65 oplog pattern library#1719
Open
vrancurel wants to merge 1 commit intodevelopment/7.10from
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## development/8.1 #1719 +/- ##
===================================================
- Coverage 60.16% 60.08% -0.09%
===================================================
Files 192 193 +1
Lines 12254 12409 +155
===================================================
+ Hits 7373 7456 +83
- Misses 4881 4953 +72
Continue to review full report at Codecov.
|
vrancurel
force-pushed
the
ft/ARSN-65-oplog-pattern-library
branch
from
6bd888a to
5edb748
Compare
vrancurel
requested review from
francoisferrand,
jonathan-gramain,
miniscruff and
tmacro
vrancurel
commented
Feb 16, 2022
vrancurel
force-pushed
the
ft/ARSN-65-oplog-pattern-library
branch
from
5edb748 to
95e70fc
Compare
vrancurel
commented
Feb 17, 2022
Contributor
Author
|
Obviously need to unit test PersistFile, PersistMem and MongoOplogInterface |
vrancurel
force-pushed
the
ft/ARSN-65-oplog-pattern-library
branch
4 times, most recently
from
028e908 to
e99867c
Compare
tmacro
requested changes
Feb 23, 2022
Contributor
tmacro
left a comment
tmacro
left a comment
There was a problem hiding this comment.
Found some stray comments but looks good overall
vrancurel
force-pushed
the
ft/ARSN-65-oplog-pattern-library
branch
3 times, most recently
from
ef81d96 to
144f713
Compare
vrancurel
force-pushed
the
ft/ARSN-65-oplog-pattern-library
branch
from
144f713 to
fc0a643
Compare
tmacro
approved these changes
Mar 14, 2022
vrancurel
force-pushed
the
ft/ARSN-65-oplog-pattern-library
branch
from
fc0a643 to
f2aeccd
Compare
miniscruff
reviewed
Mar 14, 2022
| return cb(errors.NotImplemented); | ||
| } | ||
| const filterName = filter.filterName; | ||
| async.waterfall([ |
Contributor
There was a problem hiding this comment.
we can use async await now
| const _item = {}; | ||
| _item.bucketName = seqs[i].db; | ||
| _item.key = seqs[i].entries[j].key; | ||
| if (seqs[i].entries[j].type !== undefined && |
Contributor
There was a problem hiding this comment.
This block is tabbed over quite a bit, could we break this out or maybe use some guard clauses here? I can't even tell what is going on anymore.
vrancurel
force-pushed
the
ft/ARSN-65-oplog-pattern-library
branch
3 times, most recently
from
8b8122e to
1266746
Compare
Snapshot-scan-oplog pattern with state persistence for applications requiring reading the oplog
vrancurel
force-pushed
the
ft/ARSN-65-oplog-pattern-library
branch
from
1266746 to
108b1b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snapshot-scan-oplog pattern with state persistence for applications
requiring reading the oplog