Open
Conversation
sdogruyol
commented
Oct 10, 2024
sdogruyol
commented
- Use process.terminate instead of signal(:kill)
- Terminate app process before rebuilding on Windows
- Use process.terminate instead of signal(:kill) - Terminate app process before rebuilding on Windows
zw963
added a commit
to crystal-china/sentry
that referenced
this pull request
Dec 6, 2024
1. Use process.terminate instead of signal(:kill) 2. Terminate app process before rebuilding on Windows
|
Hi, it's seem like start working on a tiny kemal hello world web server, can you help me with code review? Thanks. |
zw963
added a commit
to crystal-china/sentry
that referenced
this pull request
Dec 6, 2024
1. Use process.terminate instead of signal(:kill) 2. Terminate app process before rebuilding on Windows
zw963
added a commit
to crystal-china/sentry
that referenced
this pull request
Dec 6, 2024
1. Use process.terminate instead of signal(:kill) 2. Terminate app process before rebuilding on Windows
zw963
added a commit
to crystal-china/sentry
that referenced
this pull request
Dec 6, 2024
1. Use process.terminate instead of signal(:kill) 2. Terminate app process before rebuilding on Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.