feat: support find_arc_region and IntoIterator for GuestMemoryMmap#293
Open
ihciah wants to merge 1 commit intorust-vmm:mainfrom
Open
feat: support find_arc_region and IntoIterator for GuestMemoryMmap#293ihciah wants to merge 1 commit intorust-vmm:mainfrom
ihciah wants to merge 1 commit intorust-vmm:mainfrom
Conversation
ihciah
requested review from
alexandruag,
bonzini,
jiangliu and
roypat
as code owners
ihciah
force-pushed
the
find-arc-region
branch
2 times, most recently
from
74efacc to
08f0d2a
Compare
This allows GuestMemoryMmap to expose more operation capabilities for GuestRegionMmap. This will make it possible to optimize searches for regions. Signed-off-by: ihciah <ihciah@gmail.com>
ihciah
force-pushed
the
find-arc-region
branch
from
08f0d2a to
e9b8ec6
Compare
9 tasks
Member
|
Looks good (other than having to rebase), but maybe you should also implement |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows GuestMemoryMmap to expose more operation capabilities for GuestRegionMmap. This will make it possible to optimize searches for regions.
Summary of the PR
Implement
find_arc_regionandIntoIteratorforGuestMemoryMmap.Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.