Skip to content

s390x: add f64 tests for vec_min#2061

Merged
folkertdev merged 1 commit intorust-lang:mainfrom
RalfJung:f64-tests
Mar 12, 2026
Merged

s390x: add f64 tests for vec_min#2061
folkertdev merged 1 commit intorust-lang:mainfrom
RalfJung:f64-tests

Conversation

@RalfJung
Copy link
Member

@RalfJung RalfJung commented Mar 11, 2026

Apparently I was wrong about f32 being the hard case and the actual hard case is f64. Let's just test both of them.

@rustbot
Copy link
Collaborator

rustbot commented Mar 11, 2026

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @Amanieu, @folkertdev, @sayantn
  • @Amanieu, @folkertdev, @sayantn expanded to Amanieu, folkertdev, sayantn
  • Random selection from Amanieu, folkertdev, sayantn

@folkertdev
Copy link
Contributor

r? folkertdev

I still think f32 is the hard case for rust. it's the one that runs into target feature issues. Anyway, good to test them both.

@rustbot rustbot assigned folkertdev and unassigned Amanieu Mar 12, 2026
@folkertdev folkertdev added this pull request to the merge queue Mar 12, 2026
Merged via the queue into rust-lang:main with commit f0bb812 Mar 12, 2026
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants