add ACLE random number generation intrinsics#2050
add ACLE random number generation intrinsics#2050folkertdev wants to merge 3 commits intorust-lang:mainfrom
Conversation
|
cc @adamgemmell to check that this makes sense. Internally the feature appears to be called |
|
r? @sayantn rustbot has assigned @sayantn. Use Why was this reviewer chosen?The reviewer was selected based on:
|
crates/core_arch/src/aarch64/rand.rs
Outdated
|
|
||
| unsafe extern "unadjusted" { | ||
| #[cfg_attr( | ||
| any(target_arch = "aarch64", target_arch = "arm64ec"), |
There was a problem hiding this comment.
I don't think you need these cfg_attrs here, as this is the aarch64 module.
There was a problem hiding this comment.
right. I based this off of mte.rs so I've removed the cfg_attrs there too.
| /// is returned. | ||
| #[inline] | ||
| #[target_feature(enable = "rand")] | ||
| #[unstable(feature = "stdarch_aarch64_rand", issue = "153514")] |
There was a problem hiding this comment.
It would be nice to have some assert_instrs if possible
There was a problem hiding this comment.
those are in the test module below. Unfortunately that tests only the instruction, not the arguments, so the coverage is kind of limited.
There was a problem hiding this comment.
I think you can have them as inline assert_instrs right? Does stdarch-verify check for existence of tests for these functions? In that case we should disable the checks as we do for rdrand in x86
There was a problem hiding this comment.
Right, I guess mte.rs is just very dated. These files are ignored for stdarch-verify below
folkertdev
force-pushed
the
aarch64-rand
branch
from
a65b275 to
5db9698
Compare
3 participants
tracking issue: rust-lang/rust#153514