parser: Ensure that all nonterminals have tokens after parsing#84995
Merged
bors merged 1 commit intorust-lang:masterfrom Jun 6, 2021
Merged
parser: Ensure that all nonterminals have tokens after parsing#84995bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_nonterminalshould always result in something with tokens.This requirement wasn't satisfied in two cases:
stmtnonterminal with expression statements (e.g.0, or{}, orpath + 1) becausefn parse_stmt_without_recoveryforgot to propagateforce_collectin some cases.exprnonterminal with expressions with built-in attributes (e.g.#[allow(warnings)] 0) due to an incorrect optimization infn parse_expr_force_collect, it assumed that all expressions starting with#have their tokens collected during parsing, but that's not true if all the attributes on that expression are built-in and inert.(Discovered when trying to implement eager
cfgexpansion for all attributes #83824 (comment).)r? @Aaron1011