Skip to content

Rustdoc: JSON backend experimental impl, with new tests.#79539

Merged
bors merged 5 commits intorust-lang:masterfrom
aDotInTheVoid:json-mvp
Dec 3, 2020
Merged

Rustdoc: JSON backend experimental impl, with new tests.#79539
bors merged 5 commits intorust-lang:masterfrom
aDotInTheVoid:json-mvp

Conversation

@aDotInTheVoid
Copy link
Member

@aDotInTheVoid aDotInTheVoid commented Nov 29, 2020

Based on #75114 by @P1n3appl3

The first commit is all of #75114, but squased to 1 commit, as that was much easier to rebase onto master.

The git history is a mess, but I think I'll edit it after review, so it's obvious whats new.

Still to do

  • Update docs.
  • Add bless option to tests.
  • Add test option for multiple files in same crate.
  • Decide if the tests should check for json to be equal or subset.
  • Go through the rest of the review for the original pr. (This is open because the test system is done(ish), but stuff like not using a hashmap and using CRATE_DEF_INDEX hasn't)

I'm also sure how many of these we need to do before landing on nightly, as it would be nice to get this in tree, so it isn't effected by churn like #79125, #79041, #79061

r? @jyn514

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rustdoc-json Area: Rustdoc JSON backend merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants