Export #[inline] fns with extern indicators#73034
Merged
bors merged 7 commits intorust-lang:masterfrom Jun 19, 2020
cofibrant:nomangle-inline-linkage
Merged
Export #[inline] fns with extern indicators#73034bors merged 7 commits intorust-lang:masterfrom cofibrant:nomangle-inline-linkage
#[inline] fns with extern indicators#73034bors merged 7 commits intorust-lang:masterfrom
cofibrant:nomangle-inline-linkage
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ancient history (#36280) we stopped
#[inline]fns being codegened if they weren't used. However,#[inline]prevents symbol from appearing instaticliboutput #72463observe that when writing something like
we really do want
footo be codegened. This change makes this the case.Resolves #72944, resolves #72463 (and maybe some more)