Clean up const-hack PRs now that const if / match exist.#67657
Merged
bors merged 4 commits intorust-lang:masterfrom Dec 30, 2019
Merged
Clean up const-hack PRs now that const if / match exist.#67657bors merged 4 commits intorust-lang:masterfrom
bors merged 4 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #67627.
Cleans up these merged PRs tagged with
const-hack:const fn#63810abs,wrapping_abs,overflowing_absconst functions #63786i*::signumaconst fn. #61635reverting their contents to have the match or if expressions they originally contained.
r? @oli-obk
There's one more PR in those tagged with
const-hackthat originally wasn't merged (#65107). Reading the thread, it looks like it was originally closed because theconst-hackfor the checked arithmetic non-negligibly hurt performance, and because there was no way to manipulate the returned Option at compile time anyway (with neither const if nor const match). Would you like me to add these changes to the changes from this PR here too, now that we have the necessary features?