rustc_metadata: Privatize more things and a couple of other refactorings#66697
Merged
bors merged 13 commits intorust-lang:masterfrom Nov 29, 2019
Merged
rustc_metadata: Privatize more things and a couple of other refactorings#66697bors merged 13 commits intorust-lang:masterfrom
bors merged 13 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR continues #66496 and hits the point of diminishing returns.
All fields of
CrateRootandCrateMetadataare privatized.For read-only fields this certainly makes sense, but for a few fields updateable from outside of
rmeta.rs(mostlycreader.rs) it was done mostly for consistency, I can make thempub(crate)again if requested.cstore.rs(which became small after #66496) was merged intocreader.rs.A few things noticed while making the privacy changes were addressed in the remaining refactoring commits.
Fixes #66550
r? @eddyb @Mark-Simulacrum