Skip to content

[beta] Don't look for non-type-level assoc consts when checking trait object types#153958

Merged
rust-bors[bot] merged 1 commit intorust-lang:betafrom
fmease:beta-dyn-ace-gingerly-care
Mar 20, 2026
Merged

[beta] Don't look for non-type-level assoc consts when checking trait object types#153958
rust-bors[bot] merged 1 commit intorust-lang:betafrom
fmease:beta-dyn-ace-gingerly-care

Conversation

@fmease
Copy link
Member

@fmease fmease commented Mar 16, 2026 •
edited
Loading

Beta backport of PR #153738. Said PR can't just be rebased onto beta as it needs slight adjustments due to PR RUST-153050 not being part of beta.

Directly fixes #153731.

Blocked on backport acceptance by T-compiler (done) (nomination happened / nomination procedure happens over at #153738, not here).

@fmease fmease added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Mar 16, 2026
@rustbot rustbot added PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 16, 2026
@fmease fmease mentioned this pull request Mar 16, 2026
Merged
@fmease
Copy link
Member Author

fmease commented Mar 16, 2026

@bors rollup=never

@fmease fmease removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 16, 2026
@fmease fmease linked an issue Mar 16, 2026 that may be closed by this pull request
1.95 beta regression affecting old versions of bitvec: "... is not dyn compatible" #153731
Open
@fmease fmease force-pushed the beta-dyn-ace-gingerly-care branch from 0f60cda to bdc1b3f Compare March 17, 2026 00:54
@fmease
Copy link
Member Author

fmease commented Mar 17, 2026

Renamed tests/ui/type-alias/lack-of-wf.rs to tests/ui/type-alias/lack-of-wfcheck.rs.

@fmease fmease added S-waiting-on-t-compiler Status: Awaiting decision from T-compiler and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Mar 17, 2026
@wesleywiser wesleywiser added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 19, 2026
@apiraino apiraino added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 19, 2026
@fmease
Copy link
Member Author

fmease commented Mar 19, 2026

As I've noted in the PR description the nomination procedure should happen in the main PR, not in this backport one, so removing the beta-* labels again.

@fmease fmease removed beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. labels Mar 19, 2026
@fmease fmease changed the title [beta] [blocked] Don't look for non-type-level assoc consts when checking trait object types [beta]Don't look for non-type-level assoc consts when checking trait object types Mar 19, 2026
@fmease fmease changed the title [beta]Don't look for non-type-level assoc consts when checking trait object types [beta] Don't look for non-type-level assoc consts when checking trait object types Mar 19, 2026
@fmease fmease marked this pull request as ready for review March 19, 2026 16:58
@rustbot
Copy link
Collaborator

rustbot commented Mar 19, 2026

Some changes occurred in compiler/rustc_sanitizers

cc @rcvalle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Mar 19, 2026
@fmease
Copy link
Member Author

fmease commented Mar 19, 2026

https://forge.rust-lang.org/release/backporting.html

Change the milestone to the correct value for the beta release.
Remove the beta-nominated label. This indicates that the backport has been completed.

Applied.

@bors r=BoxyUwU

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 19, 2026

📋 This PR cannot be approved because it currently has the following label: S-waiting-on-t-compiler.

@fmease fmease removed the S-waiting-on-t-compiler Status: Awaiting decision from T-compiler label Mar 19, 2026
@fmease
Copy link
Member Author

fmease commented Mar 19, 2026

@bors r=BoxyUwU

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 19, 2026

📌 Commit bdc1b3f has been approved by BoxyUwU

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 19, 2026
@fmease fmease removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 19, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 20, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 20, 2026

☀️ Test successful - CI
Approved by: BoxyUwU
Duration: 3h 11m 36s
Pushing 951adfe to beta...

@rust-bors rust-bors bot merged commit 951adfe into rust-lang:beta Mar 20, 2026
12 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Mar 20, 2026
@fmease fmease deleted the beta-dyn-ace-gingerly-care branch March 20, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BoxyUwU BoxyUwU BoxyUwU approved these changes

Assignees

@BoxyUwU BoxyUwU

Labels

merged-by-bors This PR was explicitly merged by bors. PG-exploit-mitigations Project group: Exploit mitigations T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

1.95 beta regression affecting old versions of bitvec: "... is not dyn compatible"

5 participants

@fmease @rustbot @BoxyUwU @wesleywiser @apiraino