Add bootstrap step for stdarch-verify by xonx4l · Pull Request #153957 · rust-lang/rust

xonx4l · 2026-03-16T13:56:39Z

This PR hooks library/stdarch/crates/stdarch-verify crate into the bootstrap test runner as a step, so that we can run the stdarch-verify suite via x.py test.

Changes :
-> Added StdarchVerify in src/bootstrap/src/core/build_steps/test.rs
-> Added test::StdarchVerify in src/bootstrap/src/core/builder/mod.rs

Tests:
-> Running ./x.py test library/stdarch/crates/stdarch-verify builds compiler and std successfully.
-> All three integration tests Passes:
tests/arm.rs
tests/mips.rs
tests/x86-intel.rs
-> Doc tests for stdarch_verify also Passes.

r? @Kobzol

rustbot · 2026-03-16T13:56:45Z

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

Kobzol

The test step looks good, thank you!

I'm not sure if it's the best approach to create separate bootstrap steps for each of the stdarch test jobs though 🤔 rust-lang/stdarch#1655 (comment) mentioned the possibility of running all of the stdarch tests in a single rust-lang/rust CI job, though I'm not sure if that is practical or possible. So it would be good to come up with some larger plan for how this all will be handled.

That being said, this is a nice little incremental improvement, so let's test if it works fine on all our CI jobs. Left one nit.

View changes since this review

src/bootstrap/src/core/build_steps/test.rs

xonx4l · 2026-03-17T19:37:33Z

The test step looks good, thank you!

I'm not sure if it's the best approach to create separate bootstrap steps for each of the stdarch test jobs though 🤔 rust-lang/stdarch#1655 (comment) mentioned the possibility of running all of the stdarch tests in a single rust-lang/rust CI job, though I'm not sure if that is practical or possible. So it would be good to come up with some larger plan for how this all will be handled.

That being said, this is a nice little incremental improvement, so let's test if it works fine on all our CI jobs. Left one nit.

View changes since this review

I have idea focussed towards this route only (run the whole stdarch testsuite under a single rust-lang/rust runner and eventually fully migrate stdarch into rust-lang/rust) as mentioned by amanieu’s . For this PR I Kept the scope small so we can get one piece (stdarch-verify) hooked into bootstrap and then can see how it behaves on CI. And in Follow-ups I have idea to go through the practical and possible route . which is to me is shaping and designing intrinsic-test and core_arch in a way that they are hooked with better data on runtime and flakiness. Then we can reshape (Maybe refactor) the bootstrap steps into single bootstrap step under one job . what you think? I hope that makes sense.

Thank you!

Kobzol · 2026-03-18T16:39:35Z

@bors squash

* add bootstrap for stdarch-verify * update bootstrap snapshot * make default * update snapshots

rust-bors · 2026-03-18T16:39:57Z

🔨 4 commits were squashed into a085b68.

Kobzol · 2026-03-18T16:40:46Z

@bors r+ rollup=iffy

rust-bors · 2026-03-18T16:40:50Z

📌 Commit a085b68 has been approved by Kobzol

It is now in the queue for this repository.

@Kobzol

Add bootstrap step for stdarch-verify This PR hooks `library/stdarch/crates/stdarch-verify` crate into the bootstrap test runner as a step, so that we can run the stdarch-verify suite via x.py test. Changes : -> Added StdarchVerify in `src/bootstrap/src/core/build_steps/test.rs` -> Added `test::StdarchVerify` in `src/bootstrap/src/core/builder/mod.rs` Tests: -> Running `./x.py test library/stdarch/crates/stdarch-verify` builds compiler and std successfully. -> All three integration tests Passes: tests/arm.rs tests/mips.rs tests/x86-intel.rs -> Doc tests for `stdarch_verify` also Passes. r? @Kobzol

…uwer Rollup of 9 pull requests Successful merges: - #153957 (Add bootstrap step for stdarch-verify) - #153727 (When single impl can satisfy inference error, suggest type) - #153308 (Add hygiene annotations for tokens in `macro_rules!` bodies) - #153557 (fix inference variables leaking into HIR const literal lowering logic) - #153913 (Fix some suggestions of the `for-loops-over-fallibles` lint) - #153987 (mGCA: Lower const generic args to infer when needed) - #153992 (bootstrap: Optionally print a backtrace if a command fails) - #154036 (borrowck/type_check: remove helper left-over from unsized locals) - #154038 (merge `regions-outlives-nominal-type-*` tests into one file)

@Kobzol

Add bootstrap step for stdarch-verify This PR hooks `library/stdarch/crates/stdarch-verify` crate into the bootstrap test runner as a step, so that we can run the stdarch-verify suite via x.py test. Changes : -> Added StdarchVerify in `src/bootstrap/src/core/build_steps/test.rs` -> Added `test::StdarchVerify` in `src/bootstrap/src/core/builder/mod.rs` Tests: -> Running `./x.py test library/stdarch/crates/stdarch-verify` builds compiler and std successfully. -> All three integration tests Passes: tests/arm.rs tests/mips.rs tests/x86-intel.rs -> Doc tests for `stdarch_verify` also Passes. r? @Kobzol

@Kobzol

Add bootstrap step for stdarch-verify This PR hooks `library/stdarch/crates/stdarch-verify` crate into the bootstrap test runner as a step, so that we can run the stdarch-verify suite via x.py test. Changes : -> Added StdarchVerify in `src/bootstrap/src/core/build_steps/test.rs` -> Added `test::StdarchVerify` in `src/bootstrap/src/core/builder/mod.rs` Tests: -> Running `./x.py test library/stdarch/crates/stdarch-verify` builds compiler and std successfully. -> All three integration tests Passes: tests/arm.rs tests/mips.rs tests/x86-intel.rs -> Doc tests for `stdarch_verify` also Passes. r? @Kobzol

…uwer Rollup of 9 pull requests Successful merges: - #153957 (Add bootstrap step for stdarch-verify) - #153727 (When single impl can satisfy inference error, suggest type) - #153308 (Add hygiene annotations for tokens in `macro_rules!` bodies) - #153557 (fix inference variables leaking into HIR const literal lowering logic) - #153913 (Fix some suggestions of the `for-loops-over-fallibles` lint) - #153987 (mGCA: Lower const generic args to infer when needed) - #153992 (bootstrap: Optionally print a backtrace if a command fails) - #154036 (borrowck/type_check: remove helper left-over from unsized locals) - #154038 (merge `regions-outlives-nominal-type-*` tests into one file)

JonathanBrouwer · 2026-03-19T12:15:16Z

@bors try jobs=x86_64-gnu-distcheck

Add bootstrap step for stdarch-verify try-job: x86_64-gnu-distcheck

@Kobzol

Add bootstrap step for stdarch-verify This PR hooks `library/stdarch/crates/stdarch-verify` crate into the bootstrap test runner as a step, so that we can run the stdarch-verify suite via x.py test. Changes : -> Added StdarchVerify in `src/bootstrap/src/core/build_steps/test.rs` -> Added `test::StdarchVerify` in `src/bootstrap/src/core/builder/mod.rs` Tests: -> Running `./x.py test library/stdarch/crates/stdarch-verify` builds compiler and std successfully. -> All three integration tests Passes: tests/arm.rs tests/mips.rs tests/x86-intel.rs -> Doc tests for `stdarch_verify` also Passes. r? @Kobzol

JonathanBrouwer · 2026-03-19T12:41:28Z

@bors r-
#154062 (comment)
https://triage.rust-lang.org/gha-logs/rust-lang/rust/67727225660#L2026-03-19T12:11:30.8820882Z

rust-bors · 2026-03-19T12:41:46Z

This pull request was unapproved.

This PR was contained in a rollup (#154091), which was unapproved.

rust-bors · 2026-03-19T13:53:39Z

💔 Test for 0225b04 failed: CI. Failed job:

try - x86_64-gnu-distcheck (web logs, enhanced plaintext logs)

rust-log-analyzer · 2026-03-19T13:53:53Z

The job x86_64-gnu-distcheck failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

 INFO Book building has started
 INFO Running the html backend
 INFO HTML book written to `/tmp/distcheck/distcheck-rustc-src/build/x86_64-unknown-linux-gnu/doc/rustc`
Doc path: /tmp/distcheck/distcheck-rustc-src/build/x86_64-unknown-linux-gnu/doc/rustc/index.html
##[group]Testing stage3 stdarch-verify (x86_64-unknown-linux-gnu)
error: failed to select a version for the requirement `syn = "^2.0"` (locked to 2.0.115)
candidate versions found which didn't match: 2.0.114, 2.0.110, 2.0.106, ...
location searched: directory source `/tmp/distcheck/distcheck-rustc-src/vendor` (which is replacing registry `crates-io`)
required by package `assert-instr-macro v0.1.0 (/tmp/distcheck/distcheck-rustc-src/library/stdarch/crates/assert-instr-macro)`
perhaps a crate was updated and forgotten to be re-vendored?
As a reminder, you're using offline mode (--frozen) which can sometimes cause surprising resolution failures, if this error is too confusing you may wish to retry without `--frozen`.
Build completed unsuccessfully in 1:24:30
make: *** [Makefile:49: check] Error 1
Command `make check [workdir=/tmp/distcheck/distcheck-rustc-src]` failed with exit code 2
Created at: src/bootstrap/src/core/build_steps/test.rs:3507:5
Executed at: src/bootstrap/src/core/build_steps/test.rs:3513:10

Command has failed. Rerun with -v to see more details.
Bootstrap failed while executing `test distcheck`
Build completed unsuccessfully in 1:31:42
  local time: Thu Mar 19 13:53:04 UTC 2026
  network time: Thu, 19 Mar 2026 13:53:04 GMT
##[error]Process completed with exit code 1.

rustbot assigned Kobzol Mar 16, 2026

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 16, 2026

This comment has been minimized.

Sign in to view

Kobzol reviewed Mar 17, 2026

View reviewed changes

src/bootstrap/src/core/build_steps/test.rs Show resolved Hide resolved

Kobzol mentioned this pull request Mar 17, 2026

Teach bootstrap test/doc plumbing to handle an initial stdarch workspace subset #153951

Closed

This comment has been minimized.

Sign in to view

Add bootstrap step for stdarch-verify

a085b68

* add bootstrap for stdarch-verify * update bootstrap snapshot * make default * update snapshots

rust-bors bot force-pushed the stdarch-verify branch from c2e430c to a085b68 Compare March 18, 2026 16:39

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2026

JonathanBrouwer mentioned this pull request Mar 18, 2026

Rollup of 9 pull requests #154062

Closed

Zalathar mentioned this pull request Mar 19, 2026

Rollup of 20 pull requests #154079

Closed

JonathanBrouwer mentioned this pull request Mar 19, 2026

Rollup of 20 pull requests #154080

Closed

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Mar 19, 2026

Auto merge of #153957 - xonx4l:stdarch-verify, r=<try>

0225b04

Add bootstrap step for stdarch-verify try-job: x86_64-gnu-distcheck

JonathanBrouwer mentioned this pull request Mar 19, 2026

Rollup of 20 pull requests #154091

Closed

jyn514 mentioned this pull request Mar 19, 2026

bootstrap: Optionally print a backtrace if a command fails #153992

Merged

rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 19, 2026

Uh oh!

Conversation

xonx4l commented Mar 16, 2026

Uh oh!

rustbot commented Mar 16, 2026

Uh oh!

This comment has been minimized.

Kobzol left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

xonx4l commented Mar 17, 2026

Uh oh!

Kobzol commented Mar 18, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Mar 18, 2026

Uh oh!

Kobzol commented Mar 18, 2026

Uh oh!

rust-bors bot commented Mar 18, 2026

Uh oh!

JonathanBrouwer commented Mar 19, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-bors bot commented Mar 19, 2026

Uh oh!

rust-bors bot commented Mar 19, 2026

Uh oh!

rust-log-analyzer commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Kobzol left a comment •

edited by rustbot

Loading

JonathanBrouwer commented Mar 19, 2026 •

edited

Loading