Add arg splat experiment feature gate and stub#153697
Draft
teor2345 wants to merge 10 commits intorust-lang:mainfrom
Draft
Add arg splat experiment feature gate and stub#153697teor2345 wants to merge 10 commits intorust-lang:mainfrom
teor2345 wants to merge 10 commits intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
17 tasks
This comment has been minimized.
This comment has been minimized.
oli-obk
reviewed
Mar 11, 2026
Member
|
It should be better for someone on https://rust-lang.zulipchat.com/#narrow/channel/213817-t-lang/topic/On.20overloading/with/573924937 to review this, @oli-obk could you take over? |
oli-obk
added
the
S-blocked
Contributor
|
Let's wait for the ongoing discussion on Zulip to figure out whether we need to have a proc macro, an AST manipulating attribute (like |
rustbot
added
S-waiting-on-author
teor2345
force-pushed
the
fn-arg-splat-experiment
branch
from
89102bf to
c784a57
Compare
teor2345
force-pushed
the
fn-arg-splat-experiment
branch
from
c784a57 to
2d9e563
Compare
rustbot
added
the
A-LLVM
rustbot
added
the
A-query-system
Contributor
Author
|
I've implemented the first stage of argument type checking (THIR), but I need help with fixing:
|
This comment has been minimized.
This comment has been minimized.
teor2345
commented
Mar 20, 2026
Comment on lines
+295
to
+305
| let tuple_type = if tuple_arguments.is_splatted() { | ||
| let tuple_type = self | ||
| .try_structurally_resolve_type(call_span, formal_input_tys[tupled_arg_index]); | ||
| if tuple_type.is_ty_var() { | ||
| let tuple_len = provided_args.len().checked_sub(tupled_arg_index); | ||
| if let Some(tuple_len) = tuple_len { | ||
| // FIXME(splat before merging): how do we force the type variable to resolve to (a supertype) of the caller's tupled argument types? | ||
| Ty::new_tup_from_iter( | ||
| self.tcx, | ||
| iter::repeat_with(|| self.next_ty_var(call_span)).take(tuple_len), | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
This works but disables type inference, the old type variable should be inferred as a tuple containing the new type variables.
Comment on lines
+342
to
+350
| // FIXME(splat before merging): if splatting, update the caller's arguments to be a tuple, so MIR typecheck passes | ||
| ( | ||
| formal_input_tys[..tupled_arg_index] | ||
| .into_iter() | ||
| .cloned() | ||
| .chain(arg_types.into_iter()) | ||
| .collect(), | ||
| expected_input_tys, | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
This code de-tuples the callee's arguments, and type checks them against the caller's arguments.
But I don't know how to modify the caller so its arguments become tupled in MIR.
This comment has been minimized.
This comment has been minimized.
rustbot
added
T-clippy
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 20, 2026
…lmann Fix typos and markdown errors This PR fixes some typos and markdown errors I found while writing rust-lang#153697. I've split it out to reduce the size of that PR.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 20, 2026
…lmann Fix typos and markdown errors This PR fixes some typos and markdown errors I found while writing rust-lang#153697. I've split it out to reduce the size of that PR.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 20, 2026
…lmann Fix typos and markdown errors This PR fixes some typos and markdown errors I found while writing rust-lang#153697. I've split it out to reduce the size of that PR.
Contributor
|
☔ The latest upstream changes (presumably #153489) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the argument splatting lang experiment, and FFI overloading / C++ interop project goals:
Example code using existing unstable features:
Discussion of implementation strategy:
The PR only contains the initial stubs for the feature:
splatincomplete feature gate#[splat]attribute on function arguments#[splat]function parameter check at THIR levelOnce this PR merges, we can add further functionality, then test it out in interop tools.
TODOs