Rollup of 12 pull requests by JonathanBrouwer · Pull Request #153416 · rust-lang/rust

JonathanBrouwer · 2026-03-04T18:30:42Z

Successful merges:

miri subtree update #153402 (miri subtree update)
Lint unused features #152164 (Lint unused features)
Refactor WriteBackendMethods a bit #152801 (Refactor WriteBackendMethods a bit)
Update path separators to be available in const context #153196 (Update path separators to be available in const context)
Add #[must_use] attribute to HashMap and HashSet constructors #153204 (Add #[must_use] attribute to HashMap and HashSet constructors)
Abort after representability errors #153317 (Abort after representability errors)
Remove cycle_fatal query modifier #153276 (Remove cycle_fatal query modifier)
Tweak some of our internal #[rustc_*] TEST attributes #153300 (Tweak some of our internal #[rustc_*] TEST attributes)
use minicore in some run-make tests #153396 (use minicore in some run-make tests)
Migrationg of LintDiagnostic - part 7 #153401 (Migrationg of LintDiagnostic - part 7)
Remove a ping for myself #153406 (Remove a ping for myself)
Rename translation -> formatting #153414 (Rename translation -> formatting)

This updates the rust-version file to 3c9faa0.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@3c9faa0 Filtered ref: rust-lang/miri@4003d54 Upstream diff: rust-lang/rust@7bee525...3c9faa0 This merge was created using https://github.com/rust-lang/josh-sync.

Automatic Rustup

This updates the rust-version file to 8387095.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@8387095 Filtered ref: rust-lang/miri@0d092c8 Upstream diff: rust-lang/rust@3c9faa0...8387095 This merge was created using https://github.com/rust-lang/josh-sync.

Automatic Rustup

This updates the rust-version file to e0cb264.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@e0cb264 Filtered ref: rust-lang/miri@291e6e9 Upstream diff: rust-lang/rust@8387095...e0cb264 This merge was created using https://github.com/rust-lang/josh-sync.

Automatic Rustup

…_files Print a warning when trying to open a file in `/proc`

Fixes RefCell being borrowed mutably twice, see rust-lang/miri#4563 (comment) . There are some places in rustc where the implementation of an argument passed to a tracing span makes a nested tracing call, e.g. [here](https://github.com/rust-lang/rust/blob/f6092f224d2b1774b31033f12d0bee626943b02f/compiler/rustc_const_eval/src/interpret/step.rs#L82-L89)->[here](https://github.com/rust-lang/rust/blob/f6092f224d2b1774b31033f12d0bee626943b02f/compiler/rustc_public/src/ty.rs#L265)->[here](https://github.com/rust-lang/rust/blob/f6092f224d2b1774b31033f12d0bee626943b02f/compiler/rustc_span/src/lib.rs#L2302). This is what caused the crash. Co-authored-by: Ralf Jung <post@ralfj.de>

Fixes rust-lang/miri#4563

Miscellaneous tracing fixes and improvements

Remove duplicate "the" in documentation.

This updates the rust-version file to 5fb2ff8.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@5fb2ff8 Filtered ref: rust-lang/miri@7247ca1 Upstream diff: rust-lang/rust@e0cb264...5fb2ff8 This merge was created using https://github.com/rust-lang/josh-sync.

Fix typo in tracing.md for `tracing_separate_thread`

Automatic Rustup

This updates the rust-version file to c78a294.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@c78a294 Filtered ref: rust-lang/miri@1f76d8d Upstream diff: rust-lang/rust@5fb2ff8...c78a294 This merge was created using https://github.com/rust-lang/josh-sync.

Automatic Rustup

This updates the rust-version file to b3869b9.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: b3869b9 Filtered ref: 8ca8d84b29d11100879eadb68eb5774f85bb6977 Upstream diff: rust-lang/rust@c78a294...b3869b9 This merge was created using https://github.com/rust-lang/josh-sync.

Rustup

JonathanBrouwer · 2026-03-04T21:18:21Z

@bors try jobs=x86_64-gnu-distcheck

Rollup of 12 pull requests try-job: x86_64-gnu-distcheck

JonathanBrouwer · 2026-03-04T21:29:24Z

See #t-infra > free disk space step takes 8-10 minutes @ 💬 for discussion around disk space failures

JonathanBrouwer · 2026-03-04T21:51:29Z

@bors retry
Let's give this one more chance after the other pr succeeds(?)

rust-bors · 2026-03-04T23:40:57Z

☀️ Try build successful (CI)
Build commit: bea8ed6 (bea8ed6901e0ad8ec07ae874414e60bab32890b4, parent: b90dc1e597db0bbc0cab0eccb39747b1a9d7e607)

rust-bors · 2026-03-05T04:11:01Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 55m 52s
Pushing f8704be to main...

github-actions · 2026-03-05T04:14:11Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing b55e20a (parent) -> f8704be (this PR)

Test differences

Show 2498 test diffs

Stage 1

[incremental] tests/incremental/lint-unused-features.rs: [missing] -> pass (J3)
[run-make] tests/run-make/wasm-unexpected-features: ignore (only executed when the target is wasm32-wasip1) -> ignore (ignored on targets without Rust's LLD) (J3)
[ui] tests/ui/error-codes/E0208.rs: pass -> [missing] (J3)
[ui] tests/ui/lint/unused-features/unused-language-features.rs: [missing] -> pass (J3)
[ui] tests/ui/lint/unused-features/unused-library-features.rs: [missing] -> pass (J3)
[ui] tests/ui/lint/unused-features/used-language-features.rs: [missing] -> pass (J3)
[ui] tests/ui/lint/unused-features/used-library-features.rs: [missing] -> pass (J3)

Stage 2

[run-make] tests/run-make/wasm-unexpected-features: ignore (only executed when the target is wasm32-wasip1) -> pass (J0)
[ui] tests/ui/error-codes/E0208.rs: pass -> [missing] (J1)
[ui] tests/ui/lint/unused-features/unused-language-features.rs: [missing] -> pass (J1)
[ui] tests/ui/lint/unused-features/unused-library-features.rs: [missing] -> pass (J1)
[ui] tests/ui/lint/unused-features/used-language-features.rs: [missing] -> pass (J1)
[ui] tests/ui/lint/unused-features/used-library-features.rs: [missing] -> pass (J1)
[incremental] tests/incremental/lint-unused-features.rs: [missing] -> ignore (gcc backend is marked as ignore) (J2)
[run-make] tests/run-make/wasm-unexpected-features: ignore (only executed when the target is wasm32-wasip1) -> ignore (ignored on targets without Rust's LLD) (J4)
[incremental] tests/incremental/lint-unused-features.rs: [missing] -> pass (J5)

Additionally, 2482 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard f8704be04fe1150527fc2cf21dd44327f0fe87fb --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-android: 20m 37s -> 28m 48s (+39.6%)
dist-apple-various: 2h 5m -> 1h 34m (-24.4%)
aarch64-apple: 3h 48m -> 3h 6m (-18.4%)
dist-aarch64-msvc: 1h 50m -> 1h 30m (-18.0%)
pr-check-1: 29m 47s -> 33m 46s (+13.4%)
x86_64-gnu-nopt: 2h 19m -> 2h 36m (+12.7%)
i686-gnu-nopt-2: 2h 22m -> 2h 7m (-10.6%)
dist-aarch64-apple: 2h 20m -> 2h 7m (-9.7%)
x86_64-rust-for-linux: 49m 31s -> 54m 1s (+9.1%)
x86_64-msvc-2: 2h 15m -> 2h 28m (+9.1%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-03-05T04:14:24Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#152164	Lint unused features	`972d26ed3fb3efc3564be054adade9a7f089b459` (link)
#152801	Refactor WriteBackendMethods a bit	`da30d45aa1df935456fda815fa7ca59b6dde7c13` (link)
#153196	Update path separators to be available in const context	`5dcd6b850dadc835e9916a7be4662780609fe65f` (link)
#153204	Add `#[must_use]` attribute to `HashMap` and `HashSet` cons…	`e60ed9ef00f70a494b67dae5baea21229079e028` (link)
#153276	Remove `cycle_fatal` query modifier	`b36067a2f0d0fd3c8752b40cf4629c90af3fb04f` (link)
#153300	Tweak some of our internal `#[rustc_*]` TEST attributes	`11adcec2c82d2440363689d89cd90549f0c99129` (link)
#153317	Abort after `representability` errors	`97b4217af92ee93a47b00cbec7344211c4a48b1c` (link)
#153396	use `minicore` in some `run-make` tests	`e3e30b23cba7e4f28299893655578dceca257fc6` (link)
#153401	Migrationg of `LintDiagnostic` - part 7	`348d5107b6932770c1c0bc2517d0ddbdb15b7522` (link)
#153402	miri subtree update	`88a6ebcbf0ada4cb0704b3c3e6b1dfcf60776f1d` (link)
#153406	Remove a ping for myself	`f4fc6a801bd8794a2c108b72f1c6af6111bca35e` (link)
#153414	Rename translation -> formatting	`570e83402d5628a4fb71213232ee3641c1787478` (link)

previous master: b55e20ad90

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2026-03-05T04:51:38Z

Finished benchmarking commit (f8704be): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.6%, secondary 1.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.6%	[2.4%, 2.9%]	4
Regressions ❌ (secondary)	2.7%	[1.5%, 4.4%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.0%	[-4.0%, -4.0%]	1
All ❌✅ (primary)	2.6%	[2.4%, 2.9%]	4

Cycles

Results (primary 2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.0%	[1.9%, 2.1%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.0%	[1.9%, 2.1%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 478.218s -> 480.998s (0.58%)
Artifact size: 394.94 MiB -> 394.98 MiB (0.01%)

Zalathar · 2026-03-05T05:16:32Z

If this succeeded, then hopefully it should be fine to reopen the queue.

@bors treeopen

rust-bors · 2026-03-05T05:16:34Z

Tree is now open for merging.

The Miri Cronjob Bot and others added 30 commits February 17, 2026 05:19

Prepare for merging from rust-lang/rust

bc1a566

This updates the rust-version file to 3c9faa0.

Merge pull request rust-lang#4861 from rust-lang/rustup-2026-02-17

b3b48e5

Automatic Rustup

Prepare for merging from rust-lang/rust

7f17343

This updates the rust-version file to 8387095.

Merge pull request rust-lang#4864 from rust-lang/rustup-2026-02-18

c1e4c33

Automatic Rustup

Prepare for merging from rust-lang/rust

c57ecb0

This updates the rust-version file to e0cb264.

fix genmc build

8b03e83

Merge pull request rust-lang#4865 from rust-lang/rustup-2026-02-19

d4b4ba8

Automatic Rustup

Print a warning when trying to open a file in /proc

054d4af

clean up path check

220d514

Merge pull request rust-lang#4857 from y1lan/warning_of_openning_proc…

1650751

…_files Print a warning when trying to open a file in `/proc`

Remove RDTSC timer and always rely on Instant instead

041e3a5

Fixes rust-lang/miri#4563

Update documentation for tracing

b0b2e8c

Merge pull request rust-lang#4860 from Stypox/fix-nested-tracing

e077016

Miscellaneous tracing fixes and improvements

Fix typo in tracing.md for tracing_separate_thread

7be6269

Remove duplicate "the" in documentation.

Prepare for merging from rust-lang/rust

4a2f129

This updates the rust-version file to 5fb2ff8.

Merge pull request rust-lang#4866 from willschlitzer/patch-1

20de36c

Fix typo in tracing.md for `tracing_separate_thread`

register Miri-specific symbols with the interner

3607191

Merge pull request rust-lang#4867 from rust-lang/rustup-2026-02-22

361416e

Automatic Rustup

Prepare for merging from rust-lang/rust

e7e512d

This updates the rust-version file to c78a294.

Merge pull request rust-lang#4869 from rust-lang/rustup-2026-02-23

ca026f5

Automatic Rustup

Prepare for merging from rust-lang/rust

7ed7b2b

This updates the rust-version file to b3869b9.

Merge pull request rust-lang#4870 from RalfJung/rustup

4ab624f

Rustup

remove FIXME about size of Pointer type

2e17c9b

JonathanBrouwer mentioned this pull request Mar 4, 2026

Refactor WriteBackendMethods a bit #152801

Merged

rust-bors bot mentioned this pull request Mar 4, 2026

enable PassMode::Indirect { on_stack: true, .. } tail call arguments #153361

Merged

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Mar 4, 2026

Auto merge of #153416 - JonathanBrouwer:rollup-eezxWTV, r=<try>

bea8ed6

Rollup of 12 pull requests try-job: x86_64-gnu-distcheck

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2026

This was referenced Mar 4, 2026

library/test: always enable unstable features for miri #153369

Merged

[beta] prepare Rust 1.95.0-beta #153314

Merged

This comment has been minimized.

Sign in to view

This was referenced Mar 5, 2026

rustc_llvm: add missing - to flag-comparison logic #153419

Merged

Update dispatch2 to v0.3.1 #153423

Merged

rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 5, 2026

rust-bors bot merged commit f8704be into rust-lang:main Mar 5, 2026
13 checks passed

rust-bors bot mentioned this pull request Mar 5, 2026

Update cargo submodule #153429

Merged

cuviper added this to the 1.96.0 milestone Mar 16, 2026

Uh oh!

Conversation

JonathanBrouwer commented Mar 4, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Mar 4, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Mar 4, 2026

Uh oh!

JonathanBrouwer commented Mar 4, 2026

Uh oh!

rust-bors bot commented Mar 4, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Mar 5, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 5, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Mar 5, 2026

Uh oh!

rust-timer commented Mar 5, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Zalathar commented Mar 5, 2026

Uh oh!

rust-bors bot commented Mar 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

JonathanBrouwer commented Mar 4, 2026 •

edited by rustbot

Loading