BTreeMap::merge optimized#152418
Merged
rust-bors[bot] merged 3 commits intorust-lang:mainfrom Feb 25, 2026
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an optimized version of #151981. See ACP and tracking issue for more information on
BTreeMap::mergedoes.CC @programmerjake. Let me know what you think of how I'm using
CursorMutandIntoIterhere and whether the unsafe code here looks good. I decided to useptr::read()andptr::write()to grab the value fromCursorMutasVthan&mut V, use it within theconflictfunction, and overwrite the content of conflicting key afterward.I know this needs some polishing, especially with refactoring some redundant looking code in a nicer way, some of which could probably just be public API methods for
CursorMut. It does pass all the tests that I currently have forBTreeMap::merge(inspired fromBTreeMap::append) though, so that's good.