Skip to content

prefer alias candidates for sizedness + auto trait goals #144064

Merged
bors merged 5 commits intorust-lang:masterfrom
davidtwco:prefer-alias-over-env-for-sizedness
Oct 15, 2025
Merged

prefer alias candidates for sizedness + auto trait goals #144064
bors merged 5 commits intorust-lang:masterfrom
davidtwco:prefer-alias-over-env-for-sizedness

Conversation

@davidtwco
Copy link
Member

@davidtwco davidtwco commented Jul 17, 2025

Fixes #143992

  • abd07de: Reverts trait_sel: MetaSized always holds temporarily #144016 so that MetaSized bounds are checked properly, and updates all the tests accordingly, including making tests/ui/sized-hierarchy/incomplete-inference-issue-143992.rs fail when it shouldn't
  • 90e61db: Prefer alias candidates over parameter environment candidates for sizedness, auto and default traits. tests/ui/sized-hierarchy/incomplete-inference-issue-143992.rs passes again, but tests/ui/generic-associated-types/issue-93262.rs starts failing when it shouldn't
  • e412062: No longer require that predicates of aliases hold in well-formedness checking of the alias. tests/ui/generic-associated-types/issue-93262.rs passes again

Each commit updates all the tests to their new output so it should be easy enough to see what the impact of each change individually is. After all of the changes, tests that pass when they didn't before or vice versa:

This had a crater run in #142712 (comment) alongside some other changes.

r? @lcnr
cc #142712 (this extracts part of that change)

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. I-types-nominated Nominated for discussion during a types team meeting. merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. T-types Relevant to the types team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

where bounds regression in beta+nightly