prefer alias candidates for sizedness + auto trait goals #144064
Merged
bors merged 5 commits intorust-lang:masterfrom Oct 15, 2025
Merged
prefer alias candidates for sizedness + auto trait goals #144064bors merged 5 commits intorust-lang:masterfrom
bors merged 5 commits intorust-lang:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #143992
MetaSizedalways holds temporarily #144016 so thatMetaSizedbounds are checked properly, and updates all the tests accordingly, including makingtests/ui/sized-hierarchy/incomplete-inference-issue-143992.rsfail when it shouldn'ttests/ui/sized-hierarchy/incomplete-inference-issue-143992.rspasses again, buttests/ui/generic-associated-types/issue-93262.rsstarts failing when it shouldn'ttests/ui/generic-associated-types/issue-93262.rspasses againEach commit updates all the tests to their new output so it should be easy enough to see what the impact of each change individually is. After all of the changes, tests that pass when they didn't before or vice versa:
tests/ui/extern/extern-types-size_of_val.rsMetaSizedalways holds temporarily #144016, now correctly errorstests/ui/sized-hierarchy/incomplete-inference-issue-143992.rsMetaSizedalways holds temporarily #144016 only applied to the old solver, passing now with 90e61dbtests/ui/sized-hierarchy/overflow.rsMetaSizedalways holds temporarily #144016, now correctly errorstests/ui/generic-associated-types/issue-92096.rsC::Connecting<'placeholder>: Sendwhich is required when proving that the generator isSend. This is an instance of Tracking issue for incorrect lifetime bound errors in async #110338.tests/ui/higher-ranked/trait-bounds/normalize-under-binder/norm-before-method-resolution-opaque-type.rsThis had a crater run in #142712 (comment) alongside some other changes.
r? @lcnr
cc #142712 (this extracts part of that change)