Bootstrap command refactoring: port more Command usages to BootstrapCmd (step 2)#126822
Merged
bors merged 11 commits intorust-lang:masterfrom Jun 29, 2024
Merged
Bootstrap command refactoring: port more Command usages to BootstrapCmd (step 2)#126822bors merged 11 commits intorust-lang:masterfrom
Command usages to BootstrapCmd (step 2)#126822bors merged 11 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves more of bootstrap to use
BooststrapCmd, and also refactors the struct to allow it to serve as a proper command wrapper.Tracking issue: #126819
Best reviewed commit-by-commit, I have been adding some helper impls along the way to ease the migration, and then later I remove some of them since they were no longer needed.
r? @onur-ozkan