pass CODEGEN_BACKENDS to docker#117328
Merged
bors merged 3 commits intorust-lang:masterfrom Oct 30, 2023
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backends to build are now defined in the
CODEGEN_BACKENDSenv var. It's correctly set in CI, but wasn't passed to docker, hence cg_clif wasn't actually built in #81746.r? @Kobzol: I locally tried
CODEGEN_BACKENDS="cranelift" DEPLOY=1 src/ci/docker/run.sh dist-x86_64-linuxand this change was enough forci/run.shto read the env var.So I'll try as-is and we'll see.