Skip to content

Revert #113588 to fix bootstrap timings#114345

Merged
bors merged 1 commit intorust-lang:masterfrom
lqd:revert-113588
Aug 2, 2023
Merged

Revert #113588 to fix bootstrap timings#114345
bors merged 1 commit intorust-lang:masterfrom
lqd:revert-113588

Conversation

@lqd
Copy link
Member

@lqd lqd commented Aug 1, 2023

This reverts #113588 which seems to have broken perf's bootstrap timings via some git issue

#114318 (comment) show a newly broken benchmark, the error at the time was

fatal: Path 'src/ci/channel' exists on disk, but not in 'e62323df22ecf9c163023132d17b7114f68b72e8'.
       thread 'main' panicked at 'command did not execute successfully: cd "/home/collector/rustc-perf/rust" && "git" "show" "e62323df22ecf9c163023132d17b7114f68b72e8:src/ci/channel"
       expected success, got: exit status: 128', config.rs:1786:27

If this lands, it will reopen #101907 and annoy miri, but it could actually be an issue that would appear during the next bootstrap bump, not just rustc-perf today.

r? @ghost

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants