Split SelectionContext::select into fns that take a binder and don't#113308
Merged
bors merged 4 commits intorust-lang:masterfrom Jul 7, 2023
Merged
Split SelectionContext::select into fns that take a binder and don't#113308bors merged 4 commits intorust-lang:masterfrom
SelectionContext::select into fns that take a binder and don't#113308bors merged 4 commits intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
most usages of
SelectionContext::selectdon't need to use a binder, but wrap them in a dummy because of the signature. Let's split this out intoSelectionContext::{select,poly_select}and limit the usages of the latter.Right now, we only have 3 places where we're calling
poly_select-- fulfillment, internally within the old solver, and the auto-trait finder.r? @lcnr