Skip to content

lint/ctypes: ext. abi fn-ptr in internal abi fn#108611

Merged
bors merged 6 commits intorust-lang:masterfrom
davidtwco:issue-94223-external-abi-fn-ptr-in-internal-abi-fn
Jul 3, 2023
Merged

lint/ctypes: ext. abi fn-ptr in internal abi fn#108611
bors merged 6 commits intorust-lang:masterfrom
davidtwco:issue-94223-external-abi-fn-ptr-in-internal-abi-fn

Conversation

@davidtwco
Copy link
Member

@davidtwco davidtwco commented Mar 1, 2023

Fixes #94223.

  • In the improper ctypes lint, instead of skipping functions with internal ABIs, check that the signature doesn't contain any fn-ptr types with external ABIs that aren't FFI-safe.
  • When computing the ABI for fn-ptr types, remove an unwrap that assumed FFI-safe types in foreign fn-ptr types.
    • I'm not certain that this is the correct approach.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet