Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR seeks to stabilize
const_cstr_methods. Fixes most of #101719New const stable API
I don't think any of these methods will have any issue when
CStrbecomes a thin pointer as long asmemchris const (which also allows for conststrlen) .Notes
from_bytes_until_nulrelies onconst_slice_index, which relies onconst_trait_impls, and generally this should be avoided. After talking with Oli, it should be OK in this case because we could replace the ranges with pointer tricks if needed (worst case being those feature gates disappear). Stabilizeconst_cstr_methods#107624 (comment)from_ptrconst is deferred because it depends onconst_eval_select. I have moved this under the new flagconst_cstr_from_ptrStabilizeconst_cstr_methods#107624 (comment)cc @oli-obk I think you're the const expert
@rustbot modify labels: +T-libs-api +needs-fcp