make mk_attr_id part of ParseSess#101313
Merged
bors merged 2 commits intorust-lang:masterfrom Sep 14, 2022
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates #48685
The current
mk_attr_iduses theAtomicU32type, which is not very efficient and adds a lot of lock contention in a parallel environment.This PR refers to the task list in #48685, uses
mk_attr_idas a method of theAttrIdGeneratorstruct, and adds a new fieldattr_id_generatortoParseSess.AttrIdGeneratoruses theWorkerLocal, which has two advantages: 1.Cellis more efficient thanAtomicU32, and does not increase any lock contention. 2. We put the index of the work thread in the first few bits of the generatedAttrId, so that theAttrIdgenerated in different threads can be easily guaranteed to be unique.cc @cjgillot