Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes sure that PGO profiles (
-Cprofile-useand-Cprofile-sample-use) are tracked in depinfo, so that when they change, the compilation session will be invalidated.This approach was discussed on Zulip.
I tried it locally and it seems that the code is recompiled just with this change, and #100413 is not even needed. But it's possible that not everything required is recompiled, so we will probably want to land both changes.
Another approach to implement this could be to store the PGO profiles in
sess.parse_sess.file_depinfowhen the session is being created, but then the paths would have to be converted to a string and then to a symbol, which seemed unnecessarily complicated.CC @michaelwoerister
r? @Eh2406