Merged
Conversation
rustbot
added
the
S-waiting-on-review
lnicola
reviewed
Mar 16, 2026
| postfix_completion_for_block("const"); | ||
| } | ||
|
|
||
| #[track_caller] |
Member
There was a problem hiding this comment.
Isn't it useful to know which check_edit failed?
Contributor
Author
There was a problem hiding this comment.
Ah, you're right, #[track_caller] removes that information. Not sure what I was thinking here. Removed the change
- extract unrelated `if` out of `matches!` - in `include_references`: - add docs - use a while-let chain - add a more complex test
ada4a
force-pushed
the
push-zwprmlkyptmx
branch
from
3ca6790 to
ec677f8
Compare
lnicola
approved these changes
Mar 16, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some things I've noticed while working on https://rust-lang.zulipchat.com/#narrow/channel/185405-t-compiler.2Frust-analyzer/topic/Type.20inference.20on.20non-speculative.20file.20fails.20--.20due.20to.20.60.2E.2E.60.3F/with/579457494, which I wasn't able to finish, hence this separate small PR.
ifout ofmatches!include_references: