fix: SCIP generation should prime caches in parallel#21828
Merged
ChayimFriedman2 merged 1 commit intorust-lang:masterfrom Mar 16, 2026
Merged
fix: SCIP generation should prime caches in parallel#21828ChayimFriedman2 merged 1 commit intorust-lang:masterfrom
ChayimFriedman2 merged 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
Contributor
|
FWIW I don't like this change. I believe the default behavior should be conservative, and if SCIP wants to control cache priming it should set Actually maybe we should get rid of |
Previously load_workspace_into_db() called parallel_prime_caches() with a worker count of 1 unconditionally. This made SCIP generation slower than it needed to be. Instead, pass the number of workers explicitly, and allow the SCIP subcommand to specify the number of workers from the CLI, defaulting to the number of physical CPUs. On my M4 Macbook Pro this reduces the time taken to generate SCIP for rust-analyzer from ~39 seconds to ~35 seconds. AI disclosure: Partially written with Claude Opus 4.6.
Wilfred
force-pushed
the
parallel_prime_caches_scip
branch
from
a3e7837 to
84b3747
Compare
Wilfred
changed the title
Contributor
Author
|
OK, I've changed it to a CLI argument for the SCIP subcommand. Does this look sensible, or do you want me to push cache priming into the SCIP entry point? |
ChayimFriedman2
approved these changes
Mar 16, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously load_workspace_into_db() called parallel_prime_caches() with a worker count of 1. This made SCIP generation slower than it needed to be.
On my M4 Macbook Pro this reduces the time taken to generate SCIP for rust-analyzer from ~39 seconds to ~35 seconds.
AI disclosure: Partially written with Claude Opus 4.6.