Merged
Conversation
sanket1729
reviewed
Jul 6, 2020
Member
sanket1729
left a comment
sanket1729
left a comment
There was a problem hiding this comment.
tAck. Also needs a better commit message.
src/miniscript/decode.rs
Outdated
| Ok(term.pop().unwrap()) | ||
| } | ||
|
|
||
| fn isAndV(tokens: &mut TokenIter) -> bool { |
Member
There was a problem hiding this comment.
rustc warning: "convert the identifier to snake case: is_and_v"
apoelstra
force-pushed
the
issue_from_pull_63
branch
2 times, most recently
from
ff923ca to
ba02e75
Compare
sanket1729
approved these changes
Jul 6, 2020
Member
|
Branch build is expected to fail as it does not have the latest CI fixes |
This was referenced Jul 6, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy of #78 with the unit test fixed