-
-
Notifications
You must be signed in to change notification settings - Fork 395
Ruby 4.0: Add specs for Range#to_set #1319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| require_relative '../../spec_helper' | ||
| require_relative '../enumerable/fixtures/classes' | ||
|
|
||
| describe "Enumerable#to_set" do | ||
| it "returns a new Set created from self" do | ||
| (1..4).to_set.should == Set[1, 2, 3, 4] | ||
| (1...4).to_set.should == Set[1, 2, 3] | ||
| end | ||
|
|
||
| it "passes down passed blocks" do | ||
| (1..3).to_set { |x| x * x }.should == Set[1, 4, 9] | ||
| end | ||
|
|
||
| ruby_version_is "4.0" do | ||
| it "instantiates an object of provided as the first argument set class" do | ||
| set = nil | ||
| proc{set = (1..3).to_set(EnumerableSpecs::SetSubclass)}.should complain(/Enumerable#to_set/) | ||
| set.should be_kind_of(EnumerableSpecs::SetSubclass) | ||
| set.to_a.sort.should == [1, 2, 3] | ||
| end | ||
|
|
||
| it "raises a RangeError if the range is infinite" do | ||
| -> { (1..).to_set }.should raise_error(RangeError, "cannot convert endless range to a set") | ||
| -> { (1...).to_set }.should raise_error(RangeError, "cannot convert endless range to a set") | ||
| end | ||
| end | ||
|
|
||
| ruby_version_is ""..."4.0" do | ||
| it "instantiates an object of provided as the first argument set class" do | ||
| set = (1..3).to_set(EnumerableSpecs::SetSubclass) | ||
| set.should be_kind_of(EnumerableSpecs::SetSubclass) | ||
| set.to_a.sort.should == [1, 2, 3] | ||
| end | ||
| end | ||
|
|
||
| it "does not need explicit `require 'set'`" do | ||
| output = ruby_exe(<<~RUBY, options: '--disable-gems', args: '2>&1') | ||
| puts (1..3).to_set.to_a.inspect | ||
| RUBY | ||
|
|
||
| output.chomp.should == "[1, 2, 3]" | ||
| end | ||
| end | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what this spec achieves, that
to_setworks even ifsetisn't required?It can't really test if
to_setdoes or notrequire/autoloadSet under the hood.So I'm hesitating whether this is worth keeping, partly because
ruby_exetests are slow and the value seems minimal here, sinceSetbeing always available is or should be tested elsewhere.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a copy-paste from
core/enumerable/to_set_spec.rb, but that one has been removed in commit d871546I think these specs started as a way to test the autoload in Ruby 3.2, but since Ruby 3.2 is now the minimal version and we don't require set anywhere in the specs, it should probably be okay to just remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1323 removes it