[v638] Backport recent fixes and improvements #20813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the subset of the Vc API that is also part of `std::experimental::simd` makes it possible to transparently use `std::experimental::simd` as a GenVector template parameter. (cherry picked from commit 0e4c52a)
(cherry picked from commit 57b3602)
(cherry picked from commit 7f9d7cf)
(cherry picked from commit 8a24423)
(cherry picked from commit 29b8e84)
This is an inconcistency that we didn't catch in the CI, because no web browser is installed in the environment where we test the minimal build with implicit `webgui=OFF`. (cherry picked from commit 5ba0d05)
The ROOT libraries are now always found thanks to the RPATH mechanism, so we don't need to set `LD_LIBRARY_PATH` for tests. (cherry picked from commit 2d5efe4)
The input files for `testHistFactory` are always copied to the directory where the tests are run by CMake.
This is done in particular to avoid some usage of `GetRootSys()`. (cherry picked from commit 07c1269)
It's not good to include the standard headers in a loop, and actually causes the test to fail in my environment by somehow causing symbol lookup failures. The errors are fixed by just not including `<vector>`, which is not necessary in Cling anyway. (cherry picked from commit a82e68f)
guitargeek
requested review from
bellenot,
couet,
dpiparo,
lmoneta and
pcanal
as code owners
Test Results 21 files 21 suites 3d 11h 49m 5s ⏱️ Results for commit 85c312f. |
guitargeek
merged commit 4799367
into
root-project:v6-38-00-patches
28 of 31 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport recent fixes and improvements to the release branch.