[core] Generalize TROOT::GetShardLibDir() also on Windows #20810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
force-pushed
the
getlibdir_windows
branch
2 times, most recently
from
937a69a to
09d18ef
Compare
pcanal
reviewed
Jan 6, 2026
| DWORD needed = 0; | ||
|
|
||
| HANDLE process = GetCurrentProcess(); | ||
| if (EnumProcessModules(process, modules, sizeof(modules), &needed)) { |
Member
There was a problem hiding this comment.
Should we handle and/or warn about the failure case (eg. if there are more than 1024 libraries or any other error)? Right now, it seems that in the failure case the return value is 'empty'.
pcanal
reviewed
Jan 6, 2026
| for (unsigned int i = 0; i < count; ++i) { | ||
| wchar_t wpath[MAX_PATH]; | ||
| DWORD len = GetModuleFileNameW(modules[i], wpath, MAX_PATH); | ||
| if (!len) |
Member
There was a problem hiding this comment.
It is probably okay to ignore arbitrary library (for which the path is too long) ... but one of them might be libCore resulting in return an empty string. Can we do better and/or can we warn the user in the case libCore was not found?
This follows up on 47caba5, also generalizing the function on Windows by dynamically finding `libCore.dll` (or `Core.dll` depending on the toolchain). The goal is to avoid using `TROOT::GetRootSys()` in the implementation of this method, with the overarching goal of not having to rely on environment variables like `ROOTSYS` one day, which might not be set in some environments like the Python wheels.
guitargeek
force-pushed
the
getlibdir_windows
branch
from
09d18ef to
65fe1cd
Compare
guitargeek
changed the title
Test Results 22 files 22 suites 3d 17h 33m 53s ⏱️ Results for commit 65fe1cd. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows up on 47caba5, also generalizing the function on Windows by dynamically finding
libCore.dll(orCore.dlldepending on the toolchain).The goal is to avoid using
TROOT::GetRootSys()in the implementation of this method, with the overarching goal of not having to rely on environment variables likeROOTSYSone day, which might not be set in some environments like the Python wheels.I disclose that ChatGPT was used for this mechanical task of translating code that already existed for macOS and Linux to Windows.