fix: align share action Copy URL button with design system#9013
Draft
fix: align share action Copy URL button with design system#9013
Copy URL button with design system#9013Conversation
- Remove hardcoded `text-primary-500` icon color in `ShareDashboardPopover`; icon now inherits `accent-primary-action` from the secondary button - Make the Copy URL button full-width in `ShareDashboardPopover` - Remove non-standard `forcedStyle` 24px height and `compact` overrides from `CopyInviteLinkButton`; use standard secondary button sizing - Add `shadow-xs` (`0 1px 2px 0 rgba(0,0,0,0.05)`) to the secondary button variant in `Button.svelte` per design system spec Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
text-primary-500icon color inShareDashboardPopover; icon now inheritsaccent-primary-actionfrom the secondary buttonShareDashboardPopoverforcedStyle24px height andcompactoverrides fromCopyInviteLinkButton; use standard secondary button sizingshadow-xsto the secondary button variant inButton.svelteper the Rill Design SystemChecklist:
Developed in collaboration with Claude Code