Improve non-interactive handling in CLI and install script#8995
Open
begelundmuller wants to merge 12 commits intomainfrom
Open
Improve non-interactive handling in CLI and install script#8995begelundmuller wants to merge 12 commits intomainfrom
begelundmuller wants to merge 12 commits intomainfrom
Conversation
… InferProjectName
begelundmuller
changed the title
k-anshul
reviewed
Mar 11, 2026
k-anshul
reviewed
Mar 11, 2026
| } | ||
| if !ok { | ||
| return nil | ||
| if ch.Interactive { |
Member
There was a problem hiding this comment.
Should this be disabled in non-interactive mode just to be safe ?
| if ch.Interactive { | ||
| confirm, err := cmdutil.ConfirmPrompt(fmt.Sprintf("Are you sure you want to delete user %q?", email), "", false) | ||
| if err != nil { | ||
| if err := cmdutil.ConfirmPrompt(fmt.Sprintf("Are you sure you want to delete user %q?", email), false); err != nil { |
Member
There was a problem hiding this comment.
Similar to other comment, maybe destructive sudo commands should be disabled in non-interactive mode ?
| if !ok { | ||
| ch.PrintfWarn("Aborted\n") | ||
| return nil | ||
| if ch.Interactive { |
Member
There was a problem hiding this comment.
Similar to sudo commands maybe this should not be allowed in non-interactive mode as well ?
|
|
||
| # If the install directory is not set, or the previous installation path requires sudo, we default to installing in the current directory | ||
| if [ -z "$INSTALL_DIR" ] || ! installDirIsWritable; then | ||
| printf "Non-interactive shell detected; defaulting to install in current directory.\n" |
Member
There was a problem hiding this comment.
May be also state that Non-interactive shell detected; Previous installation at '/usr/local/bin' requires elevated permissions; defaulting to install in current directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has various refactors that improve our handling of non-interactive environments (such as coding agents):
scripts/install.shscripts/install.shto default to local directory installs in non-interactive modeSelectPrompt,ConfirmPrompt,InferProjectName)ch.Interactivechecks so commands fail clearly in non-interactive modeContributes to https://linear.app/rilldata/issue/PLAT-433/get-claude-to-vibe-code-a-rill-project-without-any-prior-manual-setup
Checklist: