Skip to content

feat: Connector form advanced keys in dropdown #8989

Open
royendo wants to merge 9 commits intomainfrom
connector-form-advanced-keys
Open

feat: Connector form advanced keys in dropdown #8989
royendo wants to merge 9 commits intomainfrom
connector-form-advanced-keys

Conversation

@royendo
Copy link
Contributor

@royendo royendo commented Mar 7, 2026

as well as docs and nit changes to forms
fix sqlite and salesforce
Screenshot 2026-03-11 at 14 57 26
Screenshot 2026-03-11 at 14 57 42

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@royendo royendo marked this pull request as ready for review March 10, 2026 14:22
@royendo royendo requested a review from AdityaHegde March 10, 2026 14:22
@royendo royendo changed the title draft: Connector form advanced keys in dropdown feat: Connector form advanced keys in dropdown Mar 10, 2026
@royendo royendo requested a review from ericokuma March 10, 2026 15:33
@royendo
Copy link
Contributor Author

royendo commented Mar 11, 2026

slack feedback form @ericokuma

  • When expanding, is it possible to add more padding to the end of the scroll form so that this expands so that the first advanced option isn't cut off?
  • this one is a bit of a nit but the scroll bar appears on top of the fields
  • By default, allow_host_access isn't in the connector preview window. Clicking on the advanced options, I see an allow_host_access: false get added to the preview YAML
  • Isn't it always Read by default? (use Di's design

@royendo
Copy link
Contributor Author

royendo commented Mar 11, 2026

looks like increasing the viewport was able to fix the e2e issues. Any reason against that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant