Skip to content

fix: inbound attachment types mismatch API values#828

Merged
gabrielmfern merged 1 commit intocanaryfrom
fix/filename-non-nullable
Feb 4, 2026
Merged

fix: inbound attachment types mismatch API values#828
gabrielmfern merged 1 commit intocanaryfrom
fix/filename-non-nullable

Conversation

@gabrielmfern
Copy link
Member

@gabrielmfern gabrielmfern commented Feb 3, 2026

Summary by cubic

Align inbound attachment types with the API by allowing null for filename, content_id, and content_disposition. This removes type mismatches in receiving email and webhook payloads.

  • Bug Fixes
    • GetReceivingEmailResponseSuccess.attachments: filename, content_id, and content_disposition are now string | null.
    • ReceivedEmailAttachment: filename and content_disposition are nullable; content_id is string | null (no longer optional).
    • Prevents type errors and parsing issues when the API returns null values.

Written for commit bbff122. Summary will update on new commits.

@gabrielmfern gabrielmfern requested a review from a team as a code owner February 3, 2026 14:44
@gabrielmfern gabrielmfern changed the title fix: match inbound attachment types match API values fix: inbound attachment types mismatch API values Feb 3, 2026
@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 3, 2026

Open in StackBlitz

npm i https://pkg.pr.new/resend/resend-node/resend@828

commit: bbff122

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@gabrielmfern gabrielmfern merged commit f47cda7 into canary Feb 4, 2026
12 of 14 checks passed
@gabrielmfern gabrielmfern deleted the fix/filename-non-nullable branch February 4, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants