Conversation
DarioSamo
force-pushed
the
d3d12-lower-commandlist-version
branch
from
b9e610f to
26f0a29
Compare
squidbus
reviewed
Dec 14, 2025
Contributor
|
You're leaking memory by not releasing the versioned command lists since QueryInterface increases the reference count. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that during the migration to plume, the minimum command list version was accidentally bumped to 7, leading to RT64 no longer booting for some users.
This changes the implementation to a scheme that gradually queries for higher versions as it requires more features instead, leaving unsupported features behind capabilities that should be checked.
At most, this implies checking for resolveTextureRegion support manually. If the application requires it and does not provide a fallback, it should just fail to initialize. For other APIs, I've assumed support for this is true as they didn't seem to be querying for anything in particular.