Conversation
There was a problem hiding this comment.
I wonder if we should call this "alwaysRender" or something else since this doesn't guarantee the item will be displayed/visible on the page.
There was a problem hiding this comment.
I've also considered changing this name, but was not sure what could fit best here. I think your suggestion could be more meaningful. We have to remember, though, that this option will only be used by a user that has actually looked for it in the future-to-be documentation of Choko.
So, should I change it to alwaysRender then?
There was a problem hiding this comment.
Yes.
I think we can go ahead and add boolean fields "alwaysRender" to row and column type (that are the actual regions)?
At some point, I believe we'll be able to use those type metadata to create self-updatable documentation for everything.
|
Hello @lucasconstantino, this looks like a good improvement. I've added some inline comments. I've seen this depends on the "responseAlter" patch and its changes are bundled here too. I'll leave comments about that to the other thread. |
|
Once you approve the other pull-request, it is probable that the changes present in this pull-request will reduce to the actual difference - not sure though. |
|
You might be right. But there were changes on the other pull request, that will require some adjustments here. Anyway, we are very close to integrate both :) |
There was a problem hiding this comment.
Missing a period on this comment.
|
Hello Lucas, please take a look at my inline comments, this is almost ready to go just needs a few tweaks, but it depends on #133. |
|
Needs to be re-rolled and also some RouteController related code need to be removed. I believe we will need a rebase and a push to a clean branch here. Maybe a rebase and a squash. |
…ons to alter the response before it's sent to the client. Fixes recidive#133. Conflicts: applications/default/extensions/route/lib/route-controller.js
Conflicts: applications/default/extensions/route/lib/route-controller.js applications/default/extensions/route/route.js
Conflicts: applications/default/extensions/layout/public/templates/column.html applications/default/extensions/layout/public/templates/layout.html applications/default/extensions/layout/public/templates/row.html
2 participants
As for today, when layout is parsing recursively through rows and columns it doesn't mind printing markup for regions that don't have content. This pull request changes that by recursively identifying empty regions (row/columns). It also introduces a region attribute called
alwaysVisiblethat when set totruewill cause a region wrapper to be output even when it has no content; mostly useful in cases when the extra markup is required for styling purposes.