Add support for BoyaMicroelectronics BY25Q16AW spi flash, Fix errors with -Werror=calloc-transposed-args

[slunk-dot]

Add support for BY25Q16AW spi flash id 0x00151068, found on a Aliexpress pico w.
Fix errors compiling with -Werror=calloc-transposed-args which now seems to be a default flag on my system.
This seems to be fixed upstream in commit 400cf2 https://sourceforge.net/p/openocd/code/ci/400cf213c05d17cede4dca4787a5533959bd2183/.
Sorry I couldn't find a easy way to split this into separate commits. Its probably better just to patch spi.c and pull the -Werror=calloc-transposed-args fix from upstream.

[lurch]

See also #126

Sorry I couldn't find a easy way to split this into separate commits.

Sounds like you'll find https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-and-deleting-branches-within-your-repository helpful then 🙂

[slunk-dot]

I did see the pull request for BYQ16B, it appears to be a similar device but has a different id.

[lurch]

Yeah, I was just suggesting that if / when support for the BY25Q16AW gets merged, it probably makes sense to merge support for the BYQ16B at the same time.

[P33M]

Can you provide a link to a datasheet for this part?
Also, the calloc error is already fixed in rpi-common.

[slunk-dot]

https://www.boyamicro.com/storage/upload/pdf/BY25Q16AW.pdf
Boyamicro now seem to go by the name BYT Semiconductor or Byte Semiconductor (byte-semi.com).
I had to search for the part number on the boyamicro site. It wasn't listed as a offered part. It does seem to be in stock at Digikey, so it's not a entirely obsolete part.