QCLINUX: qcom.config: Enable CPUidle Teo and Menu governors#707
QCLINUX: qcom.config: Enable CPUidle Teo and Menu governors#707maulik-k-shah wants to merge 1 commit intoqualcomm-linux:tech/all/configfrom
Conversation
Menu governor gets default enabled if Teo governor is not compiled in. Menu still stays as default governor when both are compiled in due to menu having higher rating than teo. Keeping Teo available helps in evaluating power and performance without spinning builds. Enable both menu and teo governors for CPUidle. Signed-off-by: Maulik Shah <maulik.shah@oss.qualcomm.com>
|
So, I guess the middle part of your commit message is your actual problem statement? Which is "I sometimes need to rebuild the kernel for testing with Teo governor and that takes several minutes" so the suggestion is to enable it for everyone every build even if nobody else is expected to use it? It's possible that I'm missing the usefulness of the Teo governor, but you can solve that by describing why this should be enabled - in your commit message. Also consider that the "most significant bit" of information in your commit message is talking about how the Kconfig and governor selection works, which seems to me to be an almost irrelevant piece of side story. Might be useful to include at the tail end to let the reviewer know that this won't affect the choice of governor... |
2 participants
Menu governor gets default enabled if Teo governor is not compiled in. Menu still stays as default governor when both are compiled in due to menu having higher rating than teo.
Keeping Teo available helps in evaluating power and performance without spinning builds.
Enable both menu and teo governors for CPUidle.