add instructions for enabling CAMX module#30
Conversation
abinjose-qualcomm
requested review from
phani-sudo,
ricardosalveti,
sbanerjee-quic and
sjakki88
|
|
||
| # The -n option is mandatory because EFI variables | ||
| # expect exact data without trailing newline characters. | ||
| echo -n "camx" > /var/data |
There was a problem hiding this comment.
Use /tmp/overlay instead or similar, /var is not recommended for temporary data like this one.
|
|
||
| # Use efivar to write the data into the runtime EFI variable | ||
| # Format: <GUID>-<Variable Name> | ||
| cd /sys/firmware/efi/efivar/ |
There was a problem hiding this comment.
No need to cd into this folder, it is also incorrect, should be /sys/firmware/efi/efivars/
| When you flash and boot ``qcom-multimedia-proprietary-image`` for the first time, | ||
| the upstream camera stack is enabled by default. Build time blacklisting cannot | ||
| help here since blacklisting upstream CAMSS modules does not lead to CAMX being | ||
| loaded. |
There was a problem hiding this comment.
I don't think we need to say that blacklisting cannot help here, best to just say what is required and later explain why.
|
|
||
| On first boot, the user needs to set the EFI variable via the sysfs node and | ||
| reboot to get CAMX enabled in subsequent boots. EFI variable setting can only be | ||
| done after booting up once. |
There was a problem hiding this comment.
Only be done after booting up once is a bit confusing, I would instead just say that EFI variable setting needs to be done at runtime, after booting the device.
| # Use efivar to write the data into the runtime EFI variable | ||
| # Format: <GUID>-<Variable Name> | ||
| cd /sys/firmware/efi/efivar/ | ||
| efivar -n 882f8c2b-9646-435f-8de5-f208ff80c1bd-VendorDtbOverlays -w -f /var/data |
There was a problem hiding this comment.
We should also say above (before the commands), that the EFI variable used to control the overlays loaded during UEFI boot is 882f8c2b-9646-435f-8de5-f208ff80c1bd-VendorDtbOverlays.
abinjose-qualcomm
force-pushed
the
enable-dtb-overlay
branch
from
352e16a to
7b6dea4
Compare
CAMX module is not enabled by default for qcom-multimedia-prop-image. While long term solutions are being discussed, add an immediate solution to allow users to experience the downstream CAMX solution. Signed-off-by: Abin Joseph <abinjose@qti.qualcomm.com>
abinjose-qualcomm
force-pushed
the
enable-dtb-overlay
branch
from
7b6dea4 to
4e7a7c4
Compare
|
Please also don't forget to go back to the comments explaining what you changed, helps moving the review forward. |
3 participants
CAMX module is not enabled by default for
qcom-multimedia-prop-image. While long term solutions are being discussed, add an immediate solution to allow users to experience the downstream CAMX solution.