[Fix] Prevent access on destroyed owner#72
Closed
jembezmamy wants to merge 1 commit intoqonto:mainfrom
Closed
Conversation
381f2f9 to
7226765
Compare
Contributor
Author
|
This approach is useful for debugging, it allows us to identify which component was not unmounted correctly. It might be useful in the future, but since the original issue is already fixed, let's close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've got some cases when Ember App is destroyed, but React component still tries to access an Ember service. This results in an error:
To prevent that, we should remove all Application Context children once the owner is destroyed.