gloo/tcp/attr: hold on to bound socket to avoid port conflict issues#429
Open
gloo/tcp/attr: hold on to bound socket to avoid port conflict issues#429
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D73148977 |
d4l3k
added a commit
that referenced
this pull request
Apr 17, 2025
…429) Summary: This is a minor refactor to attr in the TCP backend for Gloo so that we don't close the bound fd between allocating it in `lookupAddrForHostname` and binding it in `Listener`. Listener sets `SO_REUSEADDR` so it's fine for us to bind twice to the same address but we will only listen on it in `Listener`. Reviewed By: fduwjj Differential Revision: D73148977
…429) Summary: Pull Request resolved: #429 This is a minor refactor to attr in the TCP backend for Gloo so that we don't close the bound fd between allocating it in `lookupAddrForHostname` and binding it in `Listener`. Listener sets `SO_REUSEADDR` so it's fine for us to bind twice to the same address but we will only listen on it in `Listener`. Reviewed By: fduwjj Differential Revision: D73148977
|
This pull request was exported from Phabricator. Differential Revision: D73148977 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is a minor refactor to attr in the TCP backend for Gloo so that we don't close the bound fd between allocating it in
lookupAddrForHostnameand binding it inListener.Listener sets
SO_REUSEADDRso it's fine for us to bind twice to the same address but we will only listen on it inListener.Differential Revision: D73148977